From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5E32E61D46 for ; Wed, 19 Aug 2020 15:45:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4F83B25623 for ; Wed, 19 Aug 2020 15:45:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2733625617 for ; Wed, 19 Aug 2020 15:45:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DC219446C7 for ; Wed, 19 Aug 2020 15:45:05 +0200 (CEST) To: Proxmox VE development discussion , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20200813105734.3319823-1-f.gruenbichler@proxmox.com> From: Thomas Lamprecht Message-ID: <31701eea-56b8-db40-7643-4186701099c1@proxmox.com> Date: Wed, 19 Aug 2020 15:45:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101 Thunderbird/80.0 MIME-Version: 1.0 In-Reply-To: <20200813105734.3319823-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 1.399 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.899 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] www: fix PBS edit typos X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2020 13:45:37 -0000 On 13.08.20 12:57, Fabian Gr=C3=BCnbichler wrote: > and unify encryption key generation strings. >=20 > Signed-off-by: Fabian Gr=C3=BCnbichler > --- > I don't think this check for isCreate makes sense, but maybe I am > missing something? yeah, we cannot trust "original" value in the !get('isCreate') case.. Independent of that, those changes should be two separate patches anyway... >=20 > www/manager6/storage/PBSEdit.js | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) >=20 > diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6/storage/PBS= Edit.js > index dacebfdd..a418da0c 100644 > --- a/www/manager6/storage/PBSEdit.js > +++ b/www/manager6/storage/PBSEdit.js > @@ -13,16 +13,13 @@ Ext.define('Proxmox.form.PBSEncryptionCheckbox', { > blabel: (get) =3D> { > let v =3D get('value'); > let original =3D get('originalValue'); > - if (get('isCreate')) { > - return gettext('Auto-generate a client encryption key, safed pri= vately on cluster.'); > - } > if (original) { > if (!v) { > - return gettext('Warning: Existing encryption Key will be deleted!')= ; > + return gettext('Warning: Existing encryption key will be deleted!')= ; > } > return gettext('Active'); > } else { > - return gettext('Auto-generate a client encryption key, safed pri= vately on cluster filesystem'); > + return gettext('Auto-generate a client encryption key, saved pri= vately on PVE cluster.'); > } > }, > }, >=20