From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id D1E471FF12C for ; Wed, 05 Aug 2026 11:27:03 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8FEF32186F; Wed, 05 Aug 2026 11:26:58 +0200 (CEST) Message-ID: <315b27c5-9fd7-4cd8-991e-597e8990ee9a@proxmox.com> Date: Wed, 5 Aug 2026 11:26:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC qemu-server 2/4] remote migrate: collect preconditions as structured findings To: Erik Fastermann , pve-devel@lists.proxmox.com References: <20260721115827.163442-1-e.fastermann@proxmox.com> <20260721115827.163442-3-e.fastermann@proxmox.com> <26a8a6f4-0870-4bfc-807e-b75275f6d743@proxmox.com> <63311ffa-f824-4322-9360-a456e4e51401@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <63311ffa-f824-4322-9360-a456e4e51401@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785922001932 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.147 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IKPDMA4ZT6B5M22ASXSPKDNAIJWZPCCX X-Message-ID-Hash: IKPDMA4ZT6B5M22ASXSPKDNAIJWZPCCX X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 31.07.26 um 3:42 PM schrieb Erik Fastermann: >>> User-visible effect is minimal: successful migrations are unchanged. >>> Some precondition error messages are reworded and the "Establishing >>> API connection" info line is no longer printed. >> >> Do we gain anything from not printing it? Such changes can also be nicer >> in separate patches to ease reviewability and discussion. >> > > I thought printing the info line would be noise in the precondition > endpoint, which I can put in the commit message, in a separate patch. Okay, I see. I'm not sure it's too much noise, but I'm fine either way. Putting the rationale in the commit message in the same patch is enough. > > [snip] >>> +        my $findings = []; >>> +        my $plan = validate_remote_migrate_preconditions($param, >>> $findings); >> >> Style nit: why pass in $findings like this? You can just return multiple >> values instead. I'd prefer a name like $migration_info rather than $plan. >> > > I didn't want to return the findings array on every possible exit point > of the function, so I thought this would be nicer. I could add an extra > wrapper function which does this though, so I will try that. Okay, I see. I feel like an extra wrapper is not worth it. It's fine to keep it as-is IMHO (I'd still like the $plan -> $migration_info rename).