From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4A7498C1C for ; Fri, 1 Sep 2023 09:40:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2C531127D1 for ; Fri, 1 Sep 2023 09:40:12 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 1 Sep 2023 09:40:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A33F447CDE for ; Fri, 1 Sep 2023 09:40:07 +0200 (CEST) Message-ID: <314fa180-37f4-4165-b435-6bd3336c4cd9@proxmox.com> Date: Fri, 1 Sep 2023 09:40:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: pve-devel@lists.proxmox.com References: <20230830123754.606260-1-l.wagner@proxmox.com> From: Lukas Wagner In-Reply-To: <20230830123754.606260-1-l.wagner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH common/cluster 0/3] fix #4937: fix utf8 encoding issues while saving notification config X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2023 07:40:42 -0000 On 8/30/23 14:37, Lukas Wagner wrote: > These patches should fix issues with certain special characters > (e.g ü) in the notification configuration [1]. > Before, when setting a comment for an endpoint to certain values > (e.g. 'für admins'), the resulting saved configuration would > contain invalid UTF8 text. > > The reason for that was the configuration was returned from > Rust as a proper utf8 string, however it was saved to the file > system without specifying an encoding. > > > [1] https://bugzilla.proxmox.com/show_bug.cgi?id=4937 Since I'm on vacation for the next two weeks: These changes should be applied before the new notification system hits the no-subscription repo (pve-manager 8.0.5), since this bug can break notifications entirely (to fix it, one has to delete notifications.cfg and priv/notifications.cfg, or at least the faulty characters from these files) -- - Lukas