From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 716F7F5C8 for ; Fri, 21 Jul 2023 16:04:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 52F2D1FEFC for ; Fri, 21 Jul 2023 16:04:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 21 Jul 2023 16:04:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 97C5342698 for ; Fri, 21 Jul 2023 16:04:33 +0200 (CEST) Message-ID: <313fdf75-38dd-492d-8588-77fa445a7415@proxmox.com> Date: Fri, 21 Jul 2023 16:04:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: Proxmox VE development discussion , Lukas Wagner References: <20230721093910.254158-1-l.wagner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230721093910.254158-1-l.wagner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager 1/3] headerbar: use same height and padding for product name as PBS and PMG X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jul 2023 14:04:34 -0000 On 21/07/2023 11:39, Lukas Wagner wrote: > This makes the header bar look a bit less cramped and ensures consistency > if web interfaces are used side-by-side, e.g. on an ultrawide screen.> > Signed-off-by: Lukas Wagner > --- > > Notes: > Disadvantage: We loose 8px of vertical space. However, I really think > this is negligible. well we could also meed in the middle, if having 32, 34 or 36 px is enough to make it "less cramped"? As I don't like ranking subjective design tuning over actual UX, and even if just 8 px, it adds up (especially when then uses this change to argue adding some white space padding elsewhere). Also, Proxmox Backup Server, Proxmox Mail Gateway have a relatively different base UI structure too, and we normally try only hard to keep things consistent in the same product, not that it hurts on its own to do so also between products, but that shouldn't be the sole argument. Still some polishing is good, and all in all this can be fine, but as said I'd check for a trade-off.