From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9FF411FF13F for ; Thu, 12 Mar 2026 09:10:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2B10D7CAB; Thu, 12 Mar 2026 09:10:37 +0100 (CET) Message-ID: <311ced5c-481d-45f1-94ac-5787e4197a54@proxmox.com> Date: Thu, 12 Mar 2026 09:10:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH ha-manager] lrm: fix typos in log messages To: Dominik Rusovac , pve-devel@lists.proxmox.com References: <20260312071618.15408-1-d.rusovac@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260312071618.15408-1-d.rusovac@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773302967166 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.078 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NIRZJUL3537KC47MTUJBOS7CKYALQL7R X-Message-ID-Hash: NIRZJUL3537KC47MTUJBOS7CKYALQL7R X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 12.03.26 um 08:15 schrieb Dominik Rusovac: > Signed-off-by: Dominik Rusovac > --- > src/PVE/HA/LRM.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm > index e4b0ec8..09a965c 100644 > --- a/src/PVE/HA/LRM.pm > +++ b/src/PVE/HA/LRM.pm > - $haenv->log('err', "node need to be fenced - releasing agent_lock\n"); > + $haenv->log('err', "node needs to be fenced - releasing agent_lock\n"); > - "node need to be fenced during maintenance mode - releasing agent_lock\n", > + "node needs to be fenced during maintenance mode - releasing agent_lock\n", > - "get shutdown request in state 'lost_agent_lock' - " > + "got shutdown request in state 'lost_agent_lock' - " > . "detected $service_count running services", > ); > The fixes themselves look OK, but they all touch the log output that is also used for regression tests, and with that come two options: 1. either it doesn't matter because no test covers these logs, which would be rather bad on itself. 2. or, more likely, you forgot to check in the test changes required, potentially not running the harness before sending this out. Here it's 2., a running `make -C src/` test or building the whole package will result in a failure to do so. As we do not have a million of test cases and each is relatively small line count, the churn should not be to big to send it along. Please assemble a v2 doing so and ensure to run the the testsuite(s) before sending any patch, a deb package build normally should do the trick here.