From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 66AF71FF13E for ; Fri, 06 Mar 2026 11:34:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 922461E811; Fri, 6 Mar 2026 11:35:57 +0100 (CET) Message-ID: <31189b91-77db-4096-b8e3-c62fe5353f0c@proxmox.com> Date: Fri, 6 Mar 2026 11:35:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-network v3 7/9] sdn: adjust frr.conf.local merging to rust template types To: Gabriel Goller , pve-devel@lists.proxmox.com References: <20260305100331.80741-1-g.goller@proxmox.com> <20260305100331.80741-17-g.goller@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20260305100331.80741-17-g.goller@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.343 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.617 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.892 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.622 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IHKMD7VUW665UB7KCF7GNTTIOHMWI6QX X-Message-ID-Hash: IHKMD7VUW665UB7KCF7GNTTIOHMWI6QX X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/5/26 11:03 AM, Gabriel Goller wrote: > The frr object in perl which stores the whole frr config is now also > modeled in rust, so it changed a bit. Adjust the frr.conf.local merging > code so that the frr.conf.local is still merged correctly. This makes > use of the `custom_frr_config` properties scattered in many rust types. > So if we encounter a line in frr.conf.local that we need to merge, we > just throw it into this string vec and render it as-is. this commit message could use some additional information, particularly about the route-map sequence fudging and why we do it. Also we should explain here that we settled on supporting appending / creating every section that is parsed here explicitly. Some short information on the ordering changes in the generated FRR configuration, when merging frr.conf.local would be helpful as well. We might know all of this now, but this will be super helpful when revisiting this.