From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4E52D64D6C for ; Sun, 3 Jan 2021 01:56:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4081D126B6 for ; Sun, 3 Jan 2021 01:56:21 +0100 (CET) Received: from vizir.gilouweb.com (vizir.gilouweb.com [IPv6:2001:41d0:d:2147::100]) by firstgate.proxmox.com (Proxmox) with ESMTP id C4A7B126A9 for ; Sun, 3 Jan 2021 01:56:17 +0100 (CET) Received: from localhost (localhost.localdomain [127.0.0.1]) by vizir.gilouweb.com (Postfix) with ESMTP id 9A54382B412 for ; Sun, 3 Jan 2021 01:56:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=gilouweb.com; s=mail; t=1609635364; bh=ylzWqTMdoVmzWZcrH7EKP9sc7PYeC3jWc7oOP2Di5Nk=; h=To:From:Subject:Date:From; b=CEjPI7XcLSmPREsGbb9647VcdzYFblN8RADvn8d9bWOCcyHnf7WxHVSETY5r8AdFE D85d8OaKTS5Rz6qxdk32YelAC7ummng6M0F/Q7WOMdKbNGhbNSAkCXn2Xk/yxQW9R3 CC6hVLqHD8uqN/td1s27DXb9tb3g14f0XN1rRQr0S2h5wbgg4VTzS6Xj5NEeVflKH2 J5WdqgH6vEyDmng5t/78adayFIgsxX/FKFAlnUR5u/W9kmoKue8Hc/coIfyo7Z0eEk kFmlA0lXeed2RqHNxPhRVGXifrx/067BvXB5vCNm+QaPmg8+0gnOJcxnioWC6igYDv mYvf5ZWgj99sg== X-Virus-Scanned: Debian amavisd-new at vizir.gilouweb.com Received: from vizir.gilouweb.com ([127.0.0.1]) by localhost (vizir.gilouweb.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B7mNsUGk1LjU for ; Sun, 3 Jan 2021 01:55:55 +0100 (CET) Received: from [IPv6:2001:910:102d::3ca] (unknown [IPv6:2001:910:102d::3ca]) by vizir.gilouweb.com (Postfix) with ESMTPSA id DBE2282B40F for ; Sun, 3 Jan 2021 01:55:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=gilouweb.com; s=mail; t=1609635354; bh=ylzWqTMdoVmzWZcrH7EKP9sc7PYeC3jWc7oOP2Di5Nk=; h=To:From:Subject:Date:From; b=gk6uHSoBePiZ6Ie/VBn9OJhcSIdtDx12dRQW/IbA8hF5efThTbIMriyg/cxae9Hn4 ZSxnt6jQMuZz1dzBZIIieUu3cDCltzpAOPYcfh6McuHRlNb9CRRVIYf8m+pTQrIayw EqdUIe0dt8Gw4PmoiS/AiB6zsovpP4vKXRPLXAgVZ9UOv/9BiQIsuBQP7vaTlfiRIe CzY98v25Jexy/8s1ZnI07PZUY82PVsf9XGYcb6nrjgbP+hJVRjRQCqOSbqD0uGGUee 1Ik9Hwh4FofQo1TXiVFmNRlW+iqAwNFut5213+PdzEDkSOVOB82BjljsK25fKiKE1g RXkNv1B7QToLQ== To: pve-devel@lists.proxmox.com From: Gilles Pietri Message-ID: <309fe8ad-2589-5699-be3d-4f5a1ac0cbea@gilouweb.com> Date: Sun, 3 Jan 2021 01:55:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] Audio support, dummy/none X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jan 2021 00:56:21 -0000 Hi! Happy new year to everyone, especially the devs working on Proxmox, it's still awesome in 2021 ;) I'm interested in replicating a qemu audio setup that uses the dummy driver (called "none") on Proxmox, but the enum $audio_fmt (PVE/QemuServer.pm) for drivers only contains spice as a choice, which is all nice, but a bit restrictive! Since this is used only (?) to generate the audio conf (through conf_has_audio), which generate the audio devices through audio_devs, which in turn generates both the -device param and the -audiodev backend,id=xxx, it seems there wouldn't be any side effect if we fed "none" instead of spice, as the id param is valid and works the same here. I haven't tried patching that, but it might be that this would boil down to: diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index bca5669..54278e5 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -211,7 +211,7 @@ my $audio_fmt = { }, driver => { type => 'string', - enum => ['spice'], + enum => ['spice', 'none'], default => 'spice', optional => 1, description => "Driver backend for the audio device." And maybe, if we want to go further, we may want a bit of documentation also, maybe on the wiki… Also, though it's not my usecase atm, it might be interesting to add others backends as well, like alsa or pa. It was mentionned here: https://forum.proxmox.com/threads/audiodev-driver-pa-support.62317/#post-285020 However that will require second level options for the audio backends, which are not supported as it's coded. Cheers, Gilou