From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 31EC6899F for ; Wed, 16 Nov 2022 11:05:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1166A1D70A for ; Wed, 16 Nov 2022 11:05:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 16 Nov 2022 11:05:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0D39E44BAF; Wed, 16 Nov 2022 11:05:36 +0100 (CET) Message-ID: <307e7d4f-54dc-241a-93fb-589033442dca@proxmox.com> Date: Wed, 16 Nov 2022 11:05:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Content-Language: en-US To: Proxmox VE development discussion , John Hollowell References: <20221113234810.6642-1-jhollowe@johnhollowell.com> <20221113234810.6642-2-jhollowe@johnhollowell.com> From: Matthias Heiserer In-Reply-To: <20221113234810.6642-2-jhollowe@johnhollowell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: =?UTF-8?Q?0=0A=09?=AWL -0.188 Adjusted score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict =?UTF-8?Q?Alignment=0A=09?=NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF =?UTF-8?Q?Record=0A=09?=SPF_PASS -0.001 SPF: sender matches SPF =?UTF-8?Q?record=0A=09?=URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [perl.org] Subject: Re: [pve-devel] [PATCH http-server 1/1] fix #4344: http-server: ignore unused multipart headers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2022 10:05:37 -0000 (Citing the accidental off-list response) >> >> We should drop the xx and escaping of spaces, it's not needed for the >> single line. >> > > I think this would still be needed to support weird filenames? idk, I'm > not familiar with all of perl's regex flags. AFAIUI the /x and /xx is in case you want to use whitespace/newlines as separators in the regex, rather than actually matching it: https://perldoc.perl.org/perlre#/x-and-/xx Instead of e.g. `Disposition:\ (.*?);\ name=` we can then use `Disposition: (.*?); name=` >> I'm thinking of whether it would be better to include this line in the >> >> other one, or not. Probably more clearer the way it is now. > > > I think, while this is more lines, it is a better signpost that this is the > end of the multipart stuff. And if any future > data needs to be taken from the headers, it will not need to change. Agree, let's keep it that way.