From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 197A21FF17C
for <inbox@lore.proxmox.com>; Wed, 2 Apr 2025 15:42:37 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 0B4F71BCB3;
Wed, 2 Apr 2025 15:42:26 +0200 (CEST)
Message-ID: <3043bd9c-ddb7-47af-a1fe-d9749187eaa7@proxmox.com>
Date: Wed, 2 Apr 2025 15:42:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Markus Frank <m.frank@proxmox.com>
References: <20250304115803.194820-1-m.frank@proxmox.com>
<20250304115803.194820-11-m.frank@proxmox.com>
Content-Language: en-US
From: Daniel Kral <d.kral@proxmox.com>
In-Reply-To: <20250304115803.194820-11-m.frank@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.011 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH manager v14 10/12] ui: add resource mapping
view for directories
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
One comment inline, else LGTM and with this addressed consider this as:
Reviewed-by: Daniel Kral <d.kral@proxmox.com>
On 3/4/25 12:58, Markus Frank wrote:
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
> v14:
> * return HTML encoded comment
>
> www/manager6/Makefile | 1 +
> www/manager6/dc/Config.js | 10 +++++++++
> www/manager6/dc/DirMapView.js | 42 +++++++++++++++++++++++++++++++++++
> 3 files changed, 53 insertions(+)
> create mode 100644 www/manager6/dc/DirMapView.js
>
> diff --git a/www/manager6/Makefile b/www/manager6/Makefile
> index 4b8677e3..57c4d377 100644
> --- a/www/manager6/Makefile
> +++ b/www/manager6/Makefile
> @@ -189,6 +189,7 @@ JSSRC= \
> dc/RealmSyncJob.js \
> dc/PCIMapView.js \
> dc/USBMapView.js \
> + dc/DirMapView.js \
> lxc/CmdMenu.js \
> lxc/Config.js \
> lxc/CreateWizard.js \
> diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
> index 74728c83..2958fb88 100644
> --- a/www/manager6/dc/Config.js
> +++ b/www/manager6/dc/Config.js
> @@ -329,6 +329,16 @@ Ext.define('PVE.dc.Config', {
> title: gettext('USB Devices'),
> flex: 1,
> },
> + {
> + xtype: 'splitter',
> + collapsible: false,
> + performCollapse: false,
> + },
> + {
> + xtype: 'pveDcDirMapView',
> + title: gettext('Directories'),
> + flex: 1,
> + },
> ],
> },
> );
> diff --git a/www/manager6/dc/DirMapView.js b/www/manager6/dc/DirMapView.js
> new file mode 100644
> index 00000000..ff0ce633
> --- /dev/null
> +++ b/www/manager6/dc/DirMapView.js
> @@ -0,0 +1,42 @@
> +Ext.define('pve-resource-dir-tree', {
> + extend: 'Ext.data.Model',
> + idProperty: 'internalId',
> + fields: ['type', 'text', 'path', 'id', 'description', 'digest'],
> +});
> +
> +Ext.define('PVE.dc.DirMapView', {
> + extend: 'PVE.tree.ResourceMapTree',
> + alias: 'widget.pveDcDirMapView',
> +
> + editWindowClass: 'PVE.window.DirMapEditWindow',
> + baseUrl: '/cluster/mapping/dir',
> + mapIconCls: 'fa fa-folder',
> + entryIdProperty: 'path',
> +
> + store: {
> + sorters: 'text',
> + model: 'pve-resource-dir-tree',
> + data: {},
> + },
> +
> + columns: [
> + {
> + xtype: 'treecolumn',
> + text: gettext('ID/Node'),
> + dataIndex: 'text',
> + width: 200,
> + },
> + {
> + text: gettext('announce-submounts'),
> + dataIndex: 'announce-submounts',
> + },
This could also be in an advanced section as most users probably don't
want to disable this. I'm not sure about how much overhead setting
submounts in FUSE adds, but it should probably be negligible enough.
> + {
> + header: gettext('Comment'),
> + dataIndex: 'description',
> + renderer: function(value, _meta, record) {
> + return Ext.String.htmlEncode(value ?? record.data.comment);
> + },
> + flex: 1,
> + },
> + ],
> +});
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel