From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3E231BAC33 for ; Thu, 21 Mar 2024 10:33:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1C5851B3F5 for ; Thu, 21 Mar 2024 10:33:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 21 Mar 2024 10:33:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1B22E40D10 for ; Thu, 21 Mar 2024 10:33:35 +0100 (CET) Date: Thu, 21 Mar 2024 10:33:34 +0100 From: Christoph Heiss To: Fiona Ebner Cc: Proxmox VE development discussion Message-ID: <2nov4bdgzj52pgks7z6wb5o57wvxijb7yf2giulltwnqytlgi3@5am23h37hzy7> References: <20240319134851.747097-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH access-control] jobs: realm sync: fix scheduled LDAP syncs not applying attributes correctly X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Mar 2024 09:33:39 -0000 On Tue, Mar 19, 2024 at 03:57:34PM +0100, Fiona Ebner wrote: > Am 19.03.24 um 14:48 schrieb Christoph Heiss: > > This was reported by a user in the forum [0]. > > > > The cause was that the user-* standard options were not registered when > > the sync was called from the scheduler, resulting in the following > > error: > > > > pvescheduler[2849]: skipping attribute mapping 'cn'->'comment' for user 'test@samba0' - no such standard option 'user-comment' > > > > Fix this by simply importing the PVE::API2::User module, thus ensuring > > the options get registered. > > > > [0] https://forum.proxmox.com/threads/ldap-integration-comment-email-first-name-lastname.143490/ > > > > Signed-off-by: Christoph Heiss > > Fixes: cb93636 ("LDAP sync: improve validation of synced attributes") > Reviewed-by: Fiona Ebner > Tested-by: Fiona Ebner Thanks for the review & testing! > > Thank you for the fix! > > The schema for the user- properties could also be moved somewhere that > can be accessed by both API2::User module and Auth::LDAP module and > included there directly. That would be more future-proof, but as a quick > fix, this is fine too. That was actually my approach too, and I already started working on a series for exactly this. But since this definitely requires some care to catch all sites and further avoid getting it then stuck in review limbo, I thought sending a quick fix should help this get resolved faster, for now at least. :^)