From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <d.tschlatscher@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 230CC70C3D
 for <pve-devel@lists.proxmox.com>; Mon,  9 May 2022 17:13:41 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 0B30C2E2A7
 for <pve-devel@lists.proxmox.com>; Mon,  9 May 2022 17:13:41 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 66EE42E29B
 for <pve-devel@lists.proxmox.com>; Mon,  9 May 2022 17:13:40 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1F6D043255
 for <pve-devel@lists.proxmox.com>; Mon,  9 May 2022 17:13:40 +0200 (CEST)
Message-ID: <2ff81078-14ff-ee7d-8ef6-ce6c684e2500@proxmox.com>
Date: Mon, 9 May 2022 17:13:39 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To: pve-devel@lists.proxmox.com
References: <20220428084449.144884-1-m.heiserer@proxmox.com>
From: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
In-Reply-To: <20220428084449.144884-1-m.heiserer@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.718 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -1.498 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pve-devel] [PATCH v2 manager 1/2] GUI: HDEdit: check iothread
 by default
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 09 May 2022 15:13:41 -0000

I applied this patch in a few virtualized Proxmox instances. Existing
VM disk and controller settings were correctly applied, adding new
disks worked as expected.
I tried to find some settings combinations in the Editor panel that
would be wrong or nonsensical. Though, I couldn't find any problems
in this regard either.

I also ran a few (rather straightforward) benchmarks using fio and dd.
While fio write commands were only slightly faster, read benchmarks
were nearly twice as fast.
Writing with dd using IOThreads yielded a speed increase of about 50%
compared to a disk not using an IO thread.


Everything worked as advertised.

Tested-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>


On 4/28/22 10:44, Matthias Heiserer wrote:
> And move it from the advanced section to the always shown area.
>
> Because of the propertyStringSet call in onGetValues, existing VM
> show the correct iothread value.
>
> Especially in benchmarks, iothreads significantly improve IO performance.
>
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
>
> Changes from v1:
> set true by default instead of binding it
>
>   www/manager6/qemu/HDEdit.js | 19 ++++++++++---------
>   1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
> index c643ee73..b9c5cc5c 100644
> --- a/www/manager6/qemu/HDEdit.js
> +++ b/www/manager6/qemu/HDEdit.js
> @@ -251,6 +251,16 @@ Ext.define('PVE.qemu.HDInputPanel', {
>   		reference: 'discard',
>   		name: 'discard',
>   	    },
> +	    {
> +		xtype: 'proxmoxcheckbox',
> +		name: 'iothread',
> +		fieldLabel: 'IO thread',
> +		clearOnDisable: true,
> +		bind: {
> +		    disabled: '{!isVirtIO && !isSCSI}',
> +		},
> +		value: true,
> +	    },
>   	);
>   
>   	advancedColumn1.push(
> @@ -263,15 +273,6 @@ Ext.define('PVE.qemu.HDInputPanel', {
>   		    disabled: '{isVirtIO}',
>   		},
>   	    },
> -	    {
> -		xtype: 'proxmoxcheckbox',
> -		name: 'iothread',
> -		fieldLabel: 'IO thread',
> -		clearOnDisable: true,
> -		bind: {
> -		    disabled: '{!isVirtIO && !isSCSI}',
> -		},
> -	    },
>   	    {
>   		xtype: 'proxmoxcheckbox',
>   		name: 'readOnly', // `ro` in the config, we map in get/set values