From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C98AB1FF187 for ; Mon, 22 Sep 2025 19:18:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D5A91210F1; Mon, 22 Sep 2025 19:18:59 +0200 (CEST) Message-ID: <2fdb83eb-7e9f-4046-804c-8677dfb9cb96@proxmox.com> Date: Mon, 22 Sep 2025 19:18:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , n.frey@proxmox.com References: <20250919093915.21641-1-n.frey@proxmox.com> <20250919093915.21641-6-n.frey@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20250919093915.21641-6-n.frey@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758561525027 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-manager 5/5] api: add replication config read return schema X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 19.09.25 um 11:40 schrieb n.frey@proxmox.com: > From: Nicolas Frey Ah, you actually figured about re-using the SectionConfig schema here, but some commit message would be really warranted here to explain why it's fine to use the *create* schema as *return* schema. Don't get me wrong, that might be fine (I expect it too from a gut feeling, but did not actually checked and reasoned), but such things really need a basic rationale to describe why it actually is. And if it is then you can naturally switch the ACME return endpoint also to such a style. > Signed-off-by: Nicolas Frey > --- > PVE/API2/ReplicationConfig.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/API2/ReplicationConfig.pm b/PVE/API2/ReplicationConfig.pm > index 307ebe69..515afcec 100644 > --- a/PVE/API2/ReplicationConfig.pm > +++ b/PVE/API2/ReplicationConfig.pm > @@ -75,7 +75,7 @@ __PACKAGE__->register_method({ > id => get_standard_option('pve-replication-id'), > }, > }, > - returns => { type => 'object' }, > + returns => PVE::ReplicationConfig->createSchema(), > code => sub { > my ($param) = @_; > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel