From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 34E69A1240 for ; Wed, 14 Jun 2023 11:49:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1D5C219ED4 for ; Wed, 14 Jun 2023 11:49:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 14 Jun 2023 11:49:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 695E84551D for ; Wed, 14 Jun 2023 11:49:13 +0200 (CEST) Message-ID: <2f89c63e-1b97-39a8-b2b0-463bae5ef84d@proxmox.com> Date: Wed, 14 Jun 2023 11:49:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Proxmox VE development discussion , Alexander Zeidler References: <20230613134254.153081-1-a.zeidler@proxmox.com> <20230613134254.153081-2-a.zeidler@proxmox.com> From: Fiona Ebner In-Reply-To: <20230613134254.153081-2-a.zeidler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.098 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [backup.pm] Subject: Re: [pve-devel] [PATCH manager 1/4] api: backup: refactor backup permission check X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jun 2023 09:49:14 -0000 Am 13.06.23 um 15:42 schrieb Alexander Zeidler: > Unify style before adding another parameter check > > Signed-off-by: Alexander Zeidler > --- > PVE/API2/Backup.pm | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm > index 45eb47e2..cae889f4 100644 > --- a/PVE/API2/Backup.pm > +++ b/PVE/API2/Backup.pm > @@ -49,8 +49,11 @@ sub assert_param_permission_common { > raise_param_exc({ $key => "Only root may set this option."}) if exists $param->{$key}; > } > > - if (defined($param->{bwlimit}) || defined($param->{ionice}) || defined($param->{performance})) { > - $rpcenv->check($user, "/", [ 'Sys.Modify' ]); > + for my $key (qw(bwlimit ionice performance)) { > + if (defined($param->{$key})) { > + $rpcenv->check($user, "/", [ 'Sys.Modify' ]); > + last; > + } Style nit: using something like if ( grep { defined($_); } qw(...) ) { would keep the line count low ;) > } > } >