From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1C73ABA050 for ; Mon, 18 Mar 2024 17:30:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F29B41466C for ; Mon, 18 Mar 2024 17:29:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 18 Mar 2024 17:29:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2B85848AD3 for ; Mon, 18 Mar 2024 17:29:52 +0100 (CET) Date: Mon, 18 Mar 2024 17:29:51 +0100 From: Christoph Heiss To: Thomas Lamprecht Cc: Proxmox VE development discussion Message-ID: <2dqxny745xctiglrnmjdpl2gsux5wzxmcp7yzq6j2bcbskgwgd@l5vclftdp667> References: <20240312115916.502928-1-c.heiss@proxmox.com> <54fbabd6-a722-4524-8dbd-fbda3442cacd@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54fbabd6-a722-4524-8dbd-fbda3442cacd@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH installer] unconfigured: move terminal size setting before starting debug shell X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Mar 2024 16:30:24 -0000 On Mon, Mar 18, 2024 at 04:55:20PM +0100, Thomas Lamprecht wrote: > On 12/03/2024 12:59, Christoph Heiss wrote: > > Otherwise, when using the serial debug shell, the console size will be > > 0x0. This in turn breaks the TUI installer, as it cannot detect the size > > properly. > > That's ok, but... > > > > > It also adjust the size to the proper 80x24 instead of 80x25, as > > advertised in the log message. > > ... why not going the opposite direction and change the log message, > or is there some reason to go for 24 rows? > > Isn't 80x25 the standard VGA one? For VGA 80x25 is the standard size [0], yes. But for serial consoles aka. VT10x emulated terminals it is actually 80x24 [1], which basically everything uses as reference. GRUB also uses 80x24 when used over a serial interface. It spits out 24 lines at least. Probably should have noted that in the commit messages, sorry. [0] https://www.kernel.org/doc/Documentation/svga.txt (`NORMAL_VGA`) [1] https://vt100.net/dec/ek-vt100-tm-002.pdf (page 21, "Format")