From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B52521FF179 for ; Wed, 10 Dec 2025 13:23:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6B8CE1B145; Wed, 10 Dec 2025 13:24:20 +0100 (CET) Message-ID: <2dd8d9c9-27e9-4d77-b5a3-c2daf8cef886@proxmox.com> Date: Wed, 10 Dec 2025 13:24:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner To: pve-devel@lists.proxmox.com References: <20251210122009.105567-1-f.ebner@proxmox.com> Content-Language: en-US In-Reply-To: <20251210122009.105567-1-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765369450212 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.166 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 qemu-server] dbus-vmstate: fix method call on dbus object resolving to wrong instance X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 10.12.25 um 1:20 PM schrieb Fiona Ebner: > As reported in the community forum [0] and then later by Thomas, > who provided the relevant system logs, parallel migration with > '--with-conntrack-state' of multiple VMs may currently lead to a > crash upon handover: > >> kvm: Unknown savevm section or instance 'dbus-vmstate/dbus-vmstate' 0. >> Make sure that your current VM setup matches your saved VM setup, >> including any hotplugged devices >> kvm: load of migration failed: Invalid argument > > In particular, the following sequence (on my test node) > > pvesh create /nodes/pve9a1/qemu/104/dbus-vmstate --action start > pvesh create /nodes/pve9a1/qemu/105/dbus-vmstate --action start > pvesh create /nodes/pve9a1/qemu/105/dbus-vmstate --action stop > > results in the wrong service being shut down (note the unexpected ID > in the last line!): > > Dec 10 10:07:40 pve9a1 pvesh[30453]: starting dbus-vmstate helper for VM 104 > Dec 10 10:07:40 pve9a1 systemd[1]: Starting pve-dbus-vmstate@104.service - PVE DBus VMState Helper (VM 104)... > Dec 10 10:07:41 pve9a1 dbus-vmstate[30456]: pve-vmstate-104 listening on :1.55 > Dec 10 10:07:41 pve9a1 systemd[1]: Started pve-dbus-vmstate@104.service - PVE DBus VMState Helper (VM 104). > Dec 10 10:07:44 pve9a1 pvesh[30511]: starting dbus-vmstate helper for VM 105 > Dec 10 10:07:44 pve9a1 systemd[1]: Starting pve-dbus-vmstate@105.service - PVE DBus VMState Helper (VM 105)... > Dec 10 10:07:45 pve9a1 dbus-vmstate[30573]: pve-vmstate-105 listening on :1.58 > Dec 10 10:07:45 pve9a1 systemd[1]: Started pve-dbus-vmstate@105.service - PVE DBus VMState Helper (VM 105). > Dec 10 10:07:48 pve9a1 pvesh[30595]: stopping dbus-vmstate helper for VM 105 > Dec 10 10:07:48 pve9a1 dbus-vmstate[30456]: shutting down gracefully .. > Dec 10 10:07:48 pve9a1 systemd[1]: pve-dbus-vmstate@104.service: Deactivated successfully. > > So the dbus-vmstate object is removed from the wrong VM before loading > the migration state. Note that the crash is still racy, because if the > dbus-vmstate is removed on the source side for the same wrong VM before > the migration handover, the QEMU objects for both instances will still > match. > > To fix the issue, introduce a dbus_call_method() helper similar to the > already existing dbus_get_property() one. Like, this the owner is > respected even if there are multiple (queued) owners on the DBus. > > [0]: https://forum.proxmox.com/threads/176821/post-820775 > Fixes: dc76a590 ("fix #5180: migrate: integrate helper for live-migrating conntrack info") > Reported-by: Thomas Lamprecht > Signed-off-by: Fiona Ebner _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel