From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id A2B891FF0AA
	for <inbox@lore.proxmox.com>; Tue, 03 Nov 2026 17:31:14 +0100 (CET)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 9968A21457;
	Tue, 03 Nov 2026 17:31:05 +0100 (CET)
Message-ID: <2dafd96f-cef5-49b0-9677-778c20e2aa7e@proxmox.com>
Date: Tue, 3 Nov 2026 17:31:02 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH pve-storage v3 05/19] api: status: support efi-firmware in
 upload and download-url
To: Christian Ludwig <christian_ludwig@genua.de>, pve-devel@lists.proxmox.com
References: <cover.1793029144.git@genua.de>
 <67761df7a5e0682b2e7bfe2025ddc291953f2b18.1793029144.git@genua.de>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: 
 <67761df7a5e0682b2e7bfe2025ddc291953f2b18.1793029144.git@genua.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1793723462373
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.298 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: QHPSPO5CYHMB4EDFAA5XC6DMAS7MZ3Y4
X-Message-ID-Hash: QHPSPO5CYHMB4EDFAA5XC6DMAS7MZ3Y4
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 27.10.26 um 11:13 AM schrieb Christian Ludwig:
> @@ -2514,4 +2523,14 @@ sub assert_iso_content {
>      return 1;
>  }
>  
> +sub assert_efi_firmware_content {
> +    my ($path) = @_;
> +
> +    my (undef, $format) = file_size_info($path, 10, 'auto-detect', 1);

Nit: I wonder if 10 seconds is good enough? It's in a worker context so
we could also use a bit more.

> +    die "efi-firmware image is not in raw format, detected '" . ($format // 'unknown') . "'\n"
> +        if !defined($format) || $format ne 'raw';

Tiny nit: a timeout will lead to the error stating that the format was
detected as 'unknown'. More precise would be explicitly stating that the
format could not be detected if not defined, but this is really no big deal.

> +
> +    return 1;
> +}
> +
>  1;

With or without the nits addressed, consider all storage patches:

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

I am off tomorrow and will continue the review on Thursday.