From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.ebner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 64A0F9324E for <pve-devel@lists.proxmox.com>; Mon, 19 Feb 2024 13:46:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 434141F4E3 for <pve-devel@lists.proxmox.com>; Mon, 19 Feb 2024 13:46:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Mon, 19 Feb 2024 13:46:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 056DD43637 for <pve-devel@lists.proxmox.com>; Mon, 19 Feb 2024 13:46:12 +0100 (CET) Message-ID: <2d7d27cb-57fd-408e-a493-d36f1ecb204e@proxmox.com> Date: Mon, 19 Feb 2024 13:46:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Maximiliano Sandoval <m.sandoval@proxmox.com> References: <20231207131146.274773-1-m.sandoval@proxmox.com> From: Fiona Ebner <f.ebner@proxmox.com> In-Reply-To: <20231207131146.274773-1-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH widget-toolkit] ui: repo status: Simplify logic for adding warnings X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 19 Feb 2024 12:46:13 -0000 Am 07.12.23 um 14:11 schrieb Maximiliano Sandoval: > The strings were hard to translate and required some tricks like passing > 'Ceph ' as an argument. The `/main` part was also removed to simplify > the flow and UX. > But people who have a Ceph repository with 'main' component configured might be confused when getting a warning that only mentions 'no-subscription'. It's only relevant for Ceph Quincy and it turns out that the warnings are currently only displayed for Ceph Reef repositories, because the UI doesn't expect multiple Ceph versions. So I'd be fine with dropping the '/main' after all. Could you take a stab at fixing handling for multiple Ceph versions in a follow-up? I.e. fix updateStandardRepos() to detect which version is actually configured and only consider the statuses from those, as well as displaying a warning if there are mixed Ceph versions configured. > Suggested-by: Dietmar Maurer <dietmar@proxmox.com> > Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com> Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>