From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 698658074C for ; Thu, 18 Nov 2021 08:24:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 47CA616E15 for ; Thu, 18 Nov 2021 08:24:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4250516E05 for ; Thu, 18 Nov 2021 08:24:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 159C543D54 for ; Thu, 18 Nov 2021 08:24:55 +0100 (CET) Message-ID: <2cfafc98-6bcd-58ed-7797-f2a07f235d6d@proxmox.com> Date: Thu, 18 Nov 2021 08:24:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:95.0) Gecko/20100101 Thunderbird/95.0 Content-Language: en-US To: Proxmox VE development discussion , Wolfgang Bumiller References: <20211117083510.51050-1-w.bumiller@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211117083510.51050-1-w.bumiller@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.615 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.009 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH widget-toolkit] improve error handling when adding webauthn entries X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Nov 2021 07:24:56 -0000 On 17.11.21 09:35, Wolfgang Bumiller wrote: > There are cases where we directly throw a string error > (particularly, when navigator.credentials.create() fails, > for example when trying to register the same WA device to > the same user twice), which would end up with the WA window > simply not closing before. > > Signed-off-by: Wolfgang Bumiller > --- > src/window/AddWebauthn.js | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/window/AddWebauthn.js b/src/window/AddWebauthn.js > index f4a0b10..77d0914 100644 > --- a/src/window/AddWebauthn.js > +++ b/src/window/AddWebauthn.js > @@ -141,7 +141,12 @@ Ext.define('Proxmox.window.AddWebauthn', { > params, > }); > } catch (response) { > - let error = response.result.message; > + let error = response; > + if (typeof error !== "string") { why not if (typeof error === "object") { as just because it isn't a string it doesn't need to be a valid object.. > + // in case it came from an api request: > + error = error.result.message; maybe use the optional chaining operator here to make the error path a bit more robust. > + } > + > console.error(error); // for debugging if it's not displayable... should above be moved above the if then? To ensure that as much info as possible is available from the error? > Ext.Msg.alert(gettext('Error'), error); > } >