From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 859251FF165 for ; Thu, 31 Jul 2025 10:33:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5523735F82; Thu, 31 Jul 2025 10:34:40 +0200 (CEST) Message-ID: <2cb7b853-095c-4d1f-b70b-60afb9f17a05@proxmox.com> Date: Thu, 31 Jul 2025 10:34:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pve-devel@lists.proxmox.com References: <20250730162117.160498-1-f.ebner@proxmox.com> <175389699389.3840367.10876733492079005485.b4-ty@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <175389699389.3840367.10876733492079005485.b4-ty@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753950834448 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] applied: [PATCH-SERIES storage 0/3] fix #6587: lvm plugin: snapshot info: fix parsing snapshot name X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Thomas Lamprecht Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 30.07.25 um 7:36 PM schrieb Thomas Lamprecht: > On Wed, 30 Jul 2025 18:20:54 +0200, Fiona Ebner wrote: >> Volume names are allowed to contain underscores, so it is impossible >> to determine the snapshot name from just the volume name, e.g: >> snap_vm-100-disk_with_underscore_here_s_some_more.qcow2 >> >> Therefore, we need to also rely on the volume name itself to properly >> parse the snapshot name. >> >> [...] > > Applied, thanks! > > [1/3] lvm plugin: snapshot info: avoid superfluous argument for closure > commit: 819dafe516c1aedfef047b4ceb38dc49ebb2b850 > [2/3] fix #6587: lvm plugin: snapshot info: fix parsing snapshot name > commit: db2025f5ba4140fae9830154d16ae6999384bed8 > [3/3] lvm plugin: volume snapshot: actually print error when renaming > commit: fc633887dcfae776f801a8fec26d2c58c806e1ed Just wanted to thank Shannon for the bug analysis this was based on! An Analyzed-by tag would've been in order, but I forgot to add that in the hurry yesterday. Sorry about that! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel