From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BC2761FF171 for ; Fri, 29 Nov 2024 15:28:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 76BFB1AF7F; Fri, 29 Nov 2024 15:28:39 +0100 (CET) Message-ID: <2c9ba67a-f5a5-4ca8-9026-c12fed74b459@proxmox.com> Date: Fri, 29 Nov 2024 15:28:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner To: pve-devel@lists.proxmox.com References: <20240723152548.129832-1-f.ebner@proxmox.com> Content-Language: en-US In-Reply-To: <20240723152548.129832-1-f.ebner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH-SERIES qemu-server] cfg2cmd: bump minimum binary version to 5.0 and test for QEMU machine version instead of binary version X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 23.07.24 um 17:25 schrieb Fiona Ebner: > Since there are certain checks that depend on the QEMU binary version, > tests with a fixed QEMU binary version make it less likely to catch > issues on current setups, because current setups will always have a > newer QEMU binary version than the test. > > There are only three tests that explicitly want to test for the binary > version. All others are better of setting the appropriate machine > version they want to test for or just use the current machine version > if no version-specific feature is tested for. > > The minimum binary version that can be used is bumped to 5.0 which was > used in Proxmox VE 6.2, to still allow for long-term regression > testing. > > Split into bite-sized pieces for better reviewability. > Ping _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel