From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1D30FB0FE for ; Thu, 28 Apr 2022 16:19:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 13BE32537 for ; Thu, 28 Apr 2022 16:19:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DAAEC250E for ; Thu, 28 Apr 2022 16:19:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A6F6D42FBE; Thu, 28 Apr 2022 16:19:49 +0200 (CEST) Message-ID: <2c8fa406-a67e-a6b7-f4e3-4577fddd447a@proxmox.com> Date: Thu, 28 Apr 2022 16:19:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Thunderbird/100.0 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20220428115809.1661165-1-a.lauterer@proxmox.com> <20220428115809.1661165-3-a.lauterer@proxmox.com> From: Dominik Csapak In-Reply-To: <20220428115809.1661165-3-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.857 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [tools.pm] Subject: Re: [pve-devel] [PATCH manager 2/5] ceph tools: add erasure code management functions X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Apr 2022 14:19:51 -0000 imho all functions that use a PVE::RADOS object here should take one optionally (like the rest of the functions in this file, e.g. create_pool) On 4/28/22 13:58, Aaron Lauterer wrote: > Functions to manage erasure code (EC) profiles: > * add > * remove > * check if exists > * get default prefixed name > > Signed-off-by: Aaron Lauterer > --- > PVE/Ceph/Tools.pm | 49 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > > diff --git a/PVE/Ceph/Tools.pm b/PVE/Ceph/Tools.pm > index 36d7788a..0c75df0e 100644 > --- a/PVE/Ceph/Tools.pm > +++ b/PVE/Ceph/Tools.pm > @@ -531,4 +531,53 @@ sub ceph_cluster_status { > return $status; > } > > +sub ecprofile_exists { > + my ($name) = @_; > + > + my $rados = PVE::RADOS->new(); > + my $res = $rados->mon_command({ prefix => 'osd erasure-code-profile ls' }); > + > + my $profiles = { map { $_ => 1 } @$res }; > + return $profiles->{$name}; > +} > + > +sub create_ecprofile { > + my ($name, $k, $m, $failure_domain, $device_class) = @_; > + > + $failure_domain = 'host' if !$failure_domain; > + > + my $profile = [ > + "crush-failure-domain=${failure_domain}", > + "k=${k}", > + "m=${m}", > + ]; > + > + push(@$profile, "crush-device-class=${device_class}") if $device_class; > + > + my $rados = PVE::RADOS->new(); > + $rados->mon_command({ > + prefix => 'osd erasure-code-profile set', > + name => $name, > + profile => $profile, > + }); > +} > + > +sub destroy_ecprofile { > + my ($profile) = @_; > + > + my $rados = PVE::RADOS->new(); > + my $command = { > + prefix => 'osd erasure-code-profile rm', > + name => $profile, > + format => 'plain', > + }; > + return $rados->mon_command($command); > +} > + > +sub get_ecprofile_name { > + my ($name) = @_; > + return "pve_ec_${name}"; > +} > + > + > 1;