From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B8A5E1FF13B for ; Wed, 11 Mar 2026 16:58:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8BF7C32434; Wed, 11 Mar 2026 16:58:38 +0100 (CET) Message-ID: <2c7ee74c-601b-4bed-91ee-3ac40565e342@proxmox.com> Date: Wed, 11 Mar 2026 16:58:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH manager 5/7] ui: qga: add checkbox for guest-fsfreeze To: Maximiliano Sandoval , pve-devel@lists.proxmox.com References: <20260225154614.681858-1-m.sandoval@proxmox.com> <20260225154614.681858-6-m.sandoval@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260225154614.681858-6-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773244647411 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: X6CX4FK6SLCAQI5PC3OVEH34QMOE3QBL X-Message-ID-Hash: X6CX4FK6SLCAQI5PC3OVEH34QMOE3QBL X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 25.02.26 um 4:47 PM schrieb Maximiliano Sandoval: > We re-use the same components from the 'freeze-fs-on-backup' checkbox > but without referencing that this only affects backups. > > Signed-off-by: Maximiliano Sandoval > --- > www/manager6/form/AgentFeatureSelector.js | 28 +++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js > index e7fa929c..a3dda630 100644 > --- a/www/manager6/form/AgentFeatureSelector.js > +++ b/www/manager6/form/AgentFeatureSelector.js > @@ -21,6 +21,28 @@ Ext.define('PVE.form.AgentFeatureSelector', { > }, > disabled: true, > }, > + { > + xtype: 'proxmoxcheckbox', > + boxLabel: gettext('Freeze/thaw guest filesystems for consistency'), I feel like "Freeze/thaw guest filesystems during certain disk operations for consistency" would be a little more telling. > + name: 'guest-fsfreeze', > + reference: 'guest_fsfreeze', > + bind: { > + disabled: '{!enabled.checked}', > + }, > + disabled: true, > + uncheckedValue: '0', > + defaultValue: '1', > + }, > + { > + xtype: 'displayfield', > + userCls: 'pmx-hint', > + value: gettext( > + 'Freeze/thaw for guest filesystems disabled. This can lead to inconsistent disk images.', ..."for certain operations" > + ), > + bind: { > + hidden: '{guest_fsfreeze.checked}', > + }, > + }, > { > xtype: 'displayfield', > userCls: 'pmx-hint', > @@ -73,6 +95,9 @@ Ext.define('PVE.form.AgentFeatureSelector', { > if (PVE.Parser.parseBoolean(values['freeze-fs-on-backup'])) { > delete values['freeze-fs-on-backup']; > } > + if (PVE.Parser.parseBoolean(values['guest-fsfreeze'])) { > + delete values['guest-fsfreeze']; > + } > > const agentstr = PVE.Parser.printPropertyString(values, 'enabled'); > return { agent: agentstr }; > @@ -83,6 +108,9 @@ Ext.define('PVE.form.AgentFeatureSelector', { > if (!Ext.isDefined(res['freeze-fs-on-backup'])) { > res['freeze-fs-on-backup'] = 1; > } > + if (!Ext.isDefined(res['guest-fsfreeze'])) { > + res['guest-fsfreeze'] = 1; > + } > > this.callParent([res]); > },