From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id CCC551FF16B
	for <inbox@lore.proxmox.com>; Tue,  1 Jul 2025 13:54:41 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id B2E6B3C6BB;
	Tue,  1 Jul 2025 13:55:19 +0200 (CEST)
Message-ID: <2c5ca585-057c-4bc7-9b2e-c45cf99dcf49@proxmox.com>
Date: Tue, 1 Jul 2025 13:55:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: pve-devel@lists.proxmox.com
References: <20250605082322.57783-1-s.shaji@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20250605082322.57783-1-s.shaji@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.022 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pve-devel] applied: [PATCH pve_flutter_frontend v2] ui: replace
 deprecated `onBackground` property
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On 6/5/25 10:23, Shan Shaji wrote:
> As of flutter v3.22, the `onBackground` property is deprecated. The
> material guidelines suggest using the `onSurface` property instead.
> 
> https://m3.material.io/styles/color/roles#8562cf18-5cc0-44ae-b783-2e38bdb39585
> 
> For dark theme, the `onSurface` color and `onBackground` color is
> different so it's not possible to directly replace the `onBackground`
> with the `onSurface` property.To fix the issue, add a new
> `onSurfaceVariant` property to the theme and replace all
> instances of `onBackground` with `onSurfaceVariant`.
> 
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>   
>   changes since v1:
>   * rebased branch with the changes from master.
> 
>   lib/main.dart                                      |  4 ++--
>   lib/widgets/proxmox_capacity_indicator.dart        |  8 +++++---
>   lib/widgets/pve_file_selector_widget.dart          | 14 +++++++++-----
>   lib/widgets/pve_lxc_overview.dart                  |  2 +-
>   lib/widgets/pve_qemu_overview.dart                 |  5 +++--
>   lib/widgets/pve_task_log_expansiontile_widget.dart |  2 +-
>   6 files changed, 21 insertions(+), 14 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel