From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EC6E71FF189 for <inbox@lore.proxmox.com>; Fri, 4 Apr 2025 14:22:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D76A91E2AC; Fri, 4 Apr 2025 14:22:42 +0200 (CEST) Message-ID: <2c449967-7287-4e6d-939c-633a0eb6d4db@proxmox.com> Date: Fri, 4 Apr 2025 14:22:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20250307144436.122621-1-d.csapak@proxmox.com> Content-Language: en-US From: Fiona Ebner <f.ebner@proxmox.com> In-Reply-To: <20250307144436.122621-1-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server/docs v2] disable S3/S4 power states by default X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Am 07.03.25 um 15:44 schrieb Dominik Csapak: > since they make some problems (e.g. windows hybrid shutdown is enabled > by default then -> which makes vGPU problem). Libvirt/virsh also > disables that by default (and tries preventing enabling it.) > > This series introduces a new pve1 version for 9.2 machine versions, and > pins new windows guests to that. (ignore the edge case for non-version > pinned machine types on windows, so they'll get always +pve0). > > Additionally I introduce 'enable-s{3,4}' settings so that users can > still manually enable that (in case it's needed), or disable it for > older machine types. (non hotpluggable). > > I deliberately did not introduce a GUI option for the enabling of > S3/S4 power states, since I don't think it'll come up often. > (If it does, we can still add something to the UI) Except for the need to adapt the new tests, all just non-functional nits. So with or without those: Reviewed-by: Fiona Ebner <f.ebner@proxmox.com> _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel