From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B873094FEF for <pve-devel@lists.proxmox.com>; Thu, 11 Apr 2024 18:19:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9213E34EF7 for <pve-devel@lists.proxmox.com>; Thu, 11 Apr 2024 18:18:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Thu, 11 Apr 2024 18:18:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C7CA444BF0 for <pve-devel@lists.proxmox.com>; Thu, 11 Apr 2024 18:18:57 +0200 (CEST) Message-ID: <2be8a5c9-ef51-4b97-8c17-2e796c9f2801@proxmox.com> Date: Thu, 11 Apr 2024 18:18:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Fiona Ebner <f.ebner@proxmox.com> References: <20231213141747.679613-1-f.ebner@proxmox.com> Content-Language: en-GB From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20231213141747.679613-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [replication.pm, abstractconfig.pm, proxmox.com] Subject: [pve-devel] applied-series: [PATCH-SERIES v2 guest-common] replication improvements X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 11 Apr 2024 16:19:29 -0000 On 13/12/2023 15:17, Fiona Ebner wrote: > Improve error when finding a common base snapshot and fix the check if > a snapshot is needed by replication when there are volumes with > replicate setting turned off. > > First version: > https://lists.proxmox.com/pipermail/pve-devel/2023-January/055513.html > > Changes since v1: > * add an additional fix > > Fiona Ebner (3): > replication: prepare: include volumes without snapshots in the result > replication: find common base: improve error when no common base > snapshot exists > abstract config: fix snapshot needed by replication check > > src/PVE/AbstractConfig.pm | 2 +- > src/PVE/Replication.pm | 17 ++++++++++++----- > 2 files changed, 13 insertions(+), 6 deletions(-) > applied, thanks! Had some slight reservations about recommending deletion of volumes to user, but maybe I'm to paranoid about them not reading the "target" part and disregarding any basic sense..