From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7D518B84B3 for ; Mon, 4 Dec 2023 15:43:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6727EF8C9 for ; Mon, 4 Dec 2023 15:43:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 4 Dec 2023 15:43:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 254AF44810 for ; Mon, 4 Dec 2023 15:43:42 +0100 (CET) Message-ID: <2bddf575a7144eedc72b7bafd18458e6ba0140e6.camel@proxmox.com> From: Alexander Zeidler To: Proxmox VE development discussion Date: Mon, 04 Dec 2023 15:43:41 +0100 In-Reply-To: <20231201142527.213620-1-m.sandoval@proxmox.com> References: <20231201142527.213620-1-m.sandoval@proxmox.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH proxmox-i18n] use xgettext to extract translatable strings X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2023 14:43:43 -0000 >From a brief look at it: I also think it's a good idea to provide more information for translators (where it actually adds value and doesn't just bloat code). > Cons: > - In total 3 translations were marked as fuzzy. Translators will have to > review and mark them as translated again. since ~12k translations are already marked as fuzzy ... > - If using -c, gettext can't distinguish if the comment above is useful > for translators. The common practice is to add a `TRANSLATORS:` tag to > these comments. There's also "-cTAG" > + find . -iname "*.js" -path "./$(2)*" | xargs xgettext -c -s \ rather: -name