From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5EFAA7135D; Mon, 28 Jun 2021 16:55:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 55B5A2D003; Mon, 28 Jun 2021 16:55:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3C1BD2CFF2; Mon, 28 Jun 2021 16:55:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 055D1467BE; Mon, 28 Jun 2021 16:55:55 +0200 (CEST) Message-ID: <2a8cfb24-ee38-9674-0f42-61a2ef640ca5@proxmox.com> Date: Mon, 28 Jun 2021 16:55:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Dominik Csapak , pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com References: <20210624071016.21013-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210624071016.21013-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.601 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] partially-applied: [pmg-devel] [PATCH common/pve-manager/pmg-api] unify task filter api X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 14:55:56 -0000 On 24.06.21 09:10, Dominik Csapak wrote: > pmg-api: > > Dominik Csapak (3): > PMG/API2/Tasks: add typefilter > PMG/API2/Tasks: add since and until filter > PMG/API2/Tasks: add statusfilter > applied above, but adapted commit subject as it made not much sense to me, as: * PMG is rather obvious in a pmg-api repo, so not much use for the human reader * s!API2/Tasks!api: tasks!; as the "subsystem" is api, affecting the tasks endpoints, we do not really care which API version This almost looks like you just copied over the file changed, which is not really useful as I can just use `git log --stat` for that, the subject should rather be as friendly as possible for the human eye, ideally be written such that it can be copied over 1:1 in d/changelog and be also digestible easily in `git log --oneline`.