From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 07A9B1FF16F
	for <inbox@lore.proxmox.com>; Tue, 24 Jun 2025 16:34:42 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 44CFB3973C;
	Tue, 24 Jun 2025 16:35:14 +0200 (CEST)
Message-ID: <2a7f6404-d376-41d2-9811-f7a8684f0aa2@proxmox.com>
Date: Tue, 24 Jun 2025 16:34:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20250623154433.449277-1-f.ebner@proxmox.com>
 <20250623154433.449277-16-f.ebner@proxmox.com>
 <mailman.591.1750773222.395.pve-devel@lists.proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <mailman.591.1750773222.395.pve-devel@lists.proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.030 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [qemuserver.pm]
Subject: Re: [pve-devel] [RFC qemu-server 15/15] command line: switch to
 blockdev starting with machine version 10.0
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Am 24.06.25 um 15:53 schrieb DERUMIER, Alexandre via pve-devel:
>>> name":"feb8f022b5551ad1d795611f112c767","read-
>>> only":false,"size":131072},"node-name":"drive-efidisk0","throttle-
>>> group":"throttle-drive-efidisk0"}' \
> 
> It's missing 
> "key-value-pairs":{"rbd-cache-policy":"writeback"}

Would be a good catch ;) But after the recent discussion upstream [0],
the plan is to not patch QEMU, but set the option via RBD in the storage
plugin itself for EFI disks, that's why the hint is still passed along.
I added a comment that it's set via the storage layer in patch 09/15.

[0]:
https://lore.kernel.org/qemu-devel/CAOi1vP81g40nOnskY8fR8Eh7j9JMJdfD=P0+HBVUp80suNQWJQ@mail.gmail.com/

I think I'll send the next version of the storage patches relatively
shortly after part three (still quite a bit of splitting up
QemuServer.pm on the way, e.g for introducing a BlockJob module). I'll
try to send part three in the following days, I hope I get around to
also include blockdev-mirror there.

Part four is then hopefully the final one, doing all the version-guarded
switches and making all features work, fingers crossed :)


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel