From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 207C51FF0ED for ; Fri, 31 Jul 2026 15:01:18 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id DDCCA2151C; Fri, 31 Jul 2026 15:01:17 +0200 (CEST) Message-ID: <2a456fcf-ed0a-45ed-8ef1-5de144169375@proxmox.com> Date: Fri, 31 Jul 2026 15:01:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH manager v3] fix #4503: ui: qemu: add detect zeroes disk option To: Lukas Sichert , pve-devel@lists.proxmox.com References: <20260618115005.45266-1-l.sichert@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260618115005.45266-1-l.sichert@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785502864144 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.201 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DORVBWWOZDDEHVVFNPTKWMC7HJAZINA2 X-Message-ID-Hash: DORVBWWOZDDEHVVFNPTKWMC7HJAZINA2 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 18.06.26 um 1:49 PM schrieb Lukas Sichert: > When discard is enabled, qemu-server defaults to 'detect-zeroes=unmap'. > This can have a significant performance impact for zero writes on some > setups, while users might still want to keep guest discard/TRIM support > enabled. > > Allow configuring the option independently so 'discard' can stay enabled > while zero detection is disabled. Persist the checkbox state explicitly, > as the backend treats an absent value as default-enabled behavior, > resulting in 'detect-zeroes=unmap' when 'discard' is enabled. > > Link: https://bugzilla.proxmox.com/show_bug.cgi?id=4503 > Signed-off-by: Lukas Sichert > --- > > Notes: > changes from v2 to v3 (thanks @Fabian): > - add a comment explaining why this property is handled differently from > the others > > changes from v1 to v2: > - added bug-numer to commit header > - appended bug-link to commit body > > www/manager6/qemu/HDEdit.js | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js > index 1bb2bfda..2708d452 100644 > --- a/www/manager6/qemu/HDEdit.js > +++ b/www/manager6/qemu/HDEdit.js > @@ -96,6 +96,9 @@ Ext.define('PVE.qemu.HDInputPanel', { > PVE.Utils.propertyStringSet(me.drive, values.readOnly, 'ro', 'on'); > PVE.Utils.propertyStringSet(me.drive, values.cache, 'cache'); > PVE.Utils.propertyStringSet(me.drive, values.aio, 'aio'); > + // persist an explicit false value, since the backend defaults to enabled > + // when the option is omitted. > + me.drive.detect_zeroes = values.detect_zeroes ? 1 : 0; But this will now persist both, an explicit 1 and and explicit 0, needlessly cluttering the configuration in one case. Note that we already have a property that is 1 by default rather than 0, namely 'backup'. It still uses propertyStringSet(), but inverts the value passed for 'source'. I think this is a hack though, as it only works because of the explicit 'value' override. We could fix this up with something like: > propertyStringSet: function (target, source, name, value, defaultIsTrue) { > if (defaultIsTrue ? !source : source) { Alternatively, we could use something like: > propertyStringSet: function (target, isNotDefault, name, value) { > if (isNotDefault) { > target[name] = value; > } else { > delete target[name]; > } > }, and always pass an explicit 'value'. The function as a whole becomes simpler rather than more complex so maybe that's preferable. And then use it for 'backup' and 'detect_zeroes'. In fact, there is another one which is true by default, namely 'replicate', but there it's switched around by being 'noreplicate'. Still, its call to propertyStringSet() might also considered a bit hacky and only works because a custom 'value' is explicitly specified. > > ['mbps_rd', 'mbps_wr', 'iops_rd', 'iops_wr'].forEach((name) => { > let burst_name = `${name}_max`; > @@ -152,6 +155,7 @@ Ext.define('PVE.qemu.HDInputPanel', { > values.diskformat = drive.format || 'raw'; > values.cache = drive.cache || '__default__'; > values.discard = drive.discard === 'on'; > + values.detect_zeroes = PVE.Parser.parseBoolean(drive.detect_zeroes, 1); > values.ssd = PVE.Parser.parseBoolean(drive.ssd); > values.iothread = PVE.Parser.parseBoolean(drive.iothread); > values.readOnly = PVE.Parser.parseBoolean(drive.ro); > @@ -317,6 +321,12 @@ Ext.define('PVE.qemu.HDInputPanel', { > reference: 'discard', > name: 'discard', > }, > + { > + xtype: 'proxmoxcheckbox', > + fieldLabel: gettext('Detect zeroes'), > + reference: 'detect_zeroes', > + name: 'detect_zeroes', > + }, > { > xtype: 'proxmoxcheckbox', > name: 'iothread',