From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id BCAA51FF0DA for ; Thu, 19 Nov 2026 16:21:31 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id F3BC3216D5; Thu, 19 Nov 2026 16:21:29 +0100 (CET) Message-ID: <29cdefbf-116f-4479-9758-be28bb2de91c@proxmox.com> Date: Thu, 19 Nov 2026 16:21:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-sever] api: remove blank line To: Dominik Rusovac , pve-devel@lists.proxmox.com References: <20261119124402.1822168-1-d.rusovac@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20261119124402.1822168-1-d.rusovac@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795101686413 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.902 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QSO4NDDEMKO26Q52RJ73SJ2GPBZA4JFL X-Message-ID-Hash: QSO4NDDEMKO26Q52RJ73SJ2GPBZA4JFL X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 19.11.26 um 1:44 PM schrieb Dominik Rusovac: > Signed-off-by: Dominik Rusovac > --- > src/PVE/API2/Qemu.pm | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm > index b798a590..e8c93df6 100644 > --- a/src/PVE/API2/Qemu.pm > +++ b/src/PVE/API2/Qemu.pm > @@ -2395,7 +2395,6 @@ my $update_vm_api = sub { > } > > if ($param->{memory} || defined($param->{balloon})) { > - > my $memory = $param->{memory} || $conf->{pending}->{memory} || $conf->{memory}; > my $maxmem = get_current_memory($memory); > my $balloon = Our codebase has quite a few occurrences of such blank lines at the start of branches. AFAICS, neither our style guide nor our perltidy config enforce their absence. If we do want to change it, we should do it there, and the next 'make tidy' will take care of it. Personally, I prefer not having blanks in such places, but I'm not sure we have consensus about that.