From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A2D1A1FF14C for ; Fri, 29 May 2026 17:26:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 72B16F7F7; Fri, 29 May 2026 17:26:34 +0200 (CEST) Message-ID: <29ad828f-4216-44b2-8c2b-04cc94adb9db@proxmox.com> Date: Fri, 29 May 2026 17:25:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-common 1/3] json schema: display nested oneOf error messages To: Erik Fastermann , pve-devel@lists.proxmox.com References: <20260529125808.204983-1-e.fastermann@proxmox.com> <20260529125808.204983-2-e.fastermann@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260529125808.204983-2-e.fastermann@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780068330542 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [jsonschema.pm] Message-ID-Hash: SNCROMLVELTOA5KJ2JDLC36ZTMPS52D7 X-Message-ID-Hash: SNCROMLVELTOA5KJ2JDLC36ZTMPS52D7 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Nit: the title could mention that it fixes an existing issue, e.g. "fix displaying ..." Am 29.05.26 um 2:58 PM schrieb Erik Fastermann: > Correctly display the error message for each oneOf case, not just the > empty string. Nit: you could elaborate slightly more, saying that it ended up being the empty string, because the wrong key was used when doing the hash lookup. For completeness, it could have a Fixes: 9425834 ("json schema: implement 'oneOf' schema") tag. > > Signed-off-by: Erik Fastermann > --- > src/PVE/JSONSchema.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm > index 1997c70..fd10338 100644 > --- a/src/PVE/JSONSchema.pm > +++ b/src/PVE/JSONSchema.pm > @@ -1409,13 +1409,13 @@ sub check_prop { > } > > for my $inner_path (keys $inner_errors->%*) { pre-existing, but we could add a sort here for consistency (in its own patch) > - add_error($collected_errors, $inner_path, $inner_errors->{$path}); > + add_error($collected_errors, $inner_path, $inner_errors->{$inner_path}); > } > } > > if (!$is_valid) { > for my $inner_path (keys $collected_errors->%*) { same here (in the same separate patch) > - add_error($errors, $inner_path, $collected_errors->{$path}); > + add_error($errors, $inner_path, $collected_errors->{$inner_path}); > } > } > }