From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with UTF8SMTPS id 514006ADA8
for <pve-devel@lists.proxmox.com>; Wed, 17 Feb 2021 10:52:50 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with UTF8SMTP id 46840202C9
for <pve-devel@lists.proxmox.com>; Wed, 17 Feb 2021 10:52:20 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[212.186.127.180])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with UTF8SMTPS id C8E6C202BC
for <pve-devel@lists.proxmox.com>; Wed, 17 Feb 2021 10:52:19 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with UTF8SMTP id 9E39141E20
for <pve-devel@lists.proxmox.com>; Wed, 17 Feb 2021 10:52:19 +0100 (CET)
Message-ID: <27e9623d-8765-010a-3015-a13d34db6fec@proxmox.com>
Date: Wed, 17 Feb 2021 10:52:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101
Thunderbird/86.0
Content-Language: en-US
To: pve-devel@lists.proxmox.com
References: <20210215122502.23854-1-f.ebner@proxmox.com>
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20210215122502.23854-1-f.ebner@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.221 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -0.001 Looks like a legit reply (A)
RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/,
medium trust
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [tools.pm, jsonschema.pm, vzdump.pm, common.pm]
Subject: Re: [pve-devel] [PATCH-SERIES v2] loosen up mailto regex for
backwards compatibility
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 17 Feb 2021 09:52:50 -0000
LGTM, nothing obvious that is wrong
one small thing though, after this patch i cannot
have an @ in the local part of an email anymore, though
i do not think that people actually use that?
e.g. foo@bar@example.com does not work anymore
Other than that, i tested it and worked as advertised
Reviewed-By: Dominik Csapak <d.csapak@proxmox.com>
On 2/15/21 13:24, Fabian Ebner wrote:
> especially regarding the whitespace-agnostic behavior. And while we're at it,
> also use the more complete email regex from pve-common.
>
> Changes from v1:
> * re-use the email regex from pve-common
> * improve printing out mailto parameters to the cron file
>
>
> common:
>
> Fabian Ebner (2):
> sendmail: use more complete email regex and shellquote
> register email-or-username format
>
> src/PVE/JSONSchema.pm | 14 +++++++++++++-
> src/PVE/Tools.pm | 17 ++++++++++++-----
> 2 files changed, 25 insertions(+), 6 deletions(-)
>
>
> guest-common:
>
> Fabian Ebner (3):
> vzdump: command line: refactor handling prune-backups
> vzdump: command line: make sure mailto is comma-separated
> vzdump: mailto: use email-or-username-list format
>
> PVE/VZDump/Common.pm | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
>
> manager:
>
> Fabian Ebner (3):
> vzdump: refactor parsing mailto so it can be mocked
> test: vzdump: add tests for mailto
> test: vzdump: rename vzdump_new_retention_test.pl to
> vzdump_new_test.pl
>
> PVE/API2/VZDump.pm | 11 +-
> PVE/VZDump.pm | 21 +++
> test/Makefile | 8 +-
> ...w_retention_test.pl => vzdump_new_test.pl} | 174 +++++++++++++++++-
> 4 files changed, 198 insertions(+), 16 deletions(-)
> rename test/{vzdump_new_retention_test.pl => vzdump_new_test.pl} (74%)
>