From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 842211FF183 for ; Wed, 3 Dec 2025 11:57:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 433DE734F; Wed, 3 Dec 2025 11:57:31 +0100 (CET) Message-ID: <279d37d9-24ef-4976-b8cd-63a4461a836b@proxmox.com> Date: Wed, 3 Dec 2025 11:56:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Fiona Ebner References: <20251203103616.40637-1-f.ebner@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20251203103616.40637-1-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764759372891 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server] vm start: check efi vars: avoid undef Perl warning when no OS type is set X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 03.12.25 um 11:35 schrieb Fiona Ebner: > Fixes: c5b3a314 ("fix #6985: ovmf: auto-enroll Microsoft UEFI CA 2023 for Windows") > Signed-off-by: Fiona Ebner Acked-by: Thomas Lamprecht Consider above for similar future fixes of you, just apply them directly. You could still send it to the list with an "applied:" prefix already added to the subject in that submission, if you still want to keep the list/others informed. > --- > src/PVE/QemuServer.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm > index a7fbec14..d634251b 100644 > --- a/src/PVE/QemuServer.pm > +++ b/src/PVE/QemuServer.pm > @@ -5421,6 +5421,7 @@ my sub check_efi_vars { > > return if PVE::QemuConfig->is_template($conf); > return if !$conf->{efidisk0}; > + return if !$conf->{ostype}; > return if $conf->{ostype} ne 'win10' && $conf->{ostype} ne 'win11'; > > if (PVE::QemuServer::OVMF::should_enroll_ms_2023_cert($conf->{efidisk0})) { _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel