From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AA9B2C605 for ; Fri, 7 Jul 2023 15:13:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8BE1729CA5 for ; Fri, 7 Jul 2023 15:13:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 7 Jul 2023 15:13:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 429C840A7B for ; Fri, 7 Jul 2023 15:13:47 +0200 (CEST) Message-ID: <2780028e-95bf-475e-d841-24f20f537953@proxmox.com> Date: Fri, 7 Jul 2023 15:13:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Proxmox VE development discussion , Alexander Zeidler References: <20230615141445.188274-1-a.zeidler@proxmox.com> <20230615141445.188274-5-a.zeidler@proxmox.com> From: Fiona Ebner In-Reply-To: <20230615141445.188274-5-a.zeidler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.091 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [common.pm] Subject: Re: [pve-devel] [PATCH v2 guest-common 4/4] vzdump: schema: add 'pbs-entries-max' property X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jul 2023 13:13:48 -0000 Am 15.06.23 um 16:14 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > Changes from v1: > Improve description > Move description to 'performance' section > Remove arrow alignment > > > src/PVE/VZDump/Common.pm | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm > index a6fe483..83b715d 100644 > --- a/src/PVE/VZDump/Common.pm > +++ b/src/PVE/VZDump/Common.pm > @@ -88,6 +88,16 @@ PVE::JSONSchema::register_format('backup-performance', { > default => 16, > optional => 1, > }, > + 'pbs-entries-max' => { > + description => "Applies to file-based PBS backups. Increase it to enable backups of ". Maybe add "Limits the number of entries allowed in memory at a given time." as a second sentence? Style nit: I think Thomas said he prefers the continuation dot on the next line in a recent mail. > + "folders with a large amount of files. The number adds up from the maximum path ". > + "depth of a stored file/folder plus all antecedent file/folder siblings until ". > + "there (but not their recursive files).", IMHO, the last sentence is a bit hard to read. Maybe something like "For a given file/folder, the number of entries required to hold in memory is the sum of all file/folder siblings at each level in its path." is a bit more straight-forward. Or did I misinterpret it :P? > + type => 'integer', > + minimum => 1, > + default => 1048576, > + optional => 1, > + }, > }); > > my $confdesc = {