From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E1714BB0EC for ; Fri, 22 Mar 2024 15:39:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CA32B8185 for ; Fri, 22 Mar 2024 15:39:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 22 Mar 2024 15:39:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0F1AF41865 for ; Fri, 22 Mar 2024 15:39:20 +0100 (CET) Message-ID: <276c489f-6f2e-4971-8df7-6d0d9268d168@proxmox.com> Date: Fri, 22 Mar 2024 15:39:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Stefan Sterz References: <20240313084401.46297-1-f.weber@proxmox.com> Content-Language: en-US From: Friedrich Weber In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.077 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] ui: pool members: avoid setting request parameter for all edit windows X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2024 14:39:20 -0000 On 14/03/2024 15:43, Stefan Sterz wrote: > On Wed Mar 13, 2024 at 9:44 AM CET, Friedrich Weber wrote: >> Currently, after adding a storage to a pool, opening any edit window >> will send a GET request with a superfluous `poolid` parameter and >> cause a parameter verification error in the GUI. This breaks all edit >> windows of the current session. A workaround is to reload the current >> browser session. >> >> This happens because the `PVE.pool.AddStorage` component inadvertently >> adds `poolid` to an `extraRequestParams` object that is shared by all >> instances of `Proxmox.window.Edit`, affecting all edit windows in the >> current session. Fix this by instead creating a new object that is >> local to the component. >> >> Fixes: cd731902b7a724b1ab747276f9c6343734f1d8cb >> Signed-off-by: Friedrich Weber >> --- >> >> Notes: >> To check if we have this problem at other places, I did a quick search >> for `extraRequestParams` in PVE+PBS: Seems like for all other usages, >> the object is created fresh already. >> >> www/manager6/grid/PoolMembers.js | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMembers.js >> index 75f20cab..61e27dff 100644 >> --- a/www/manager6/grid/PoolMembers.js >> +++ b/www/manager6/grid/PoolMembers.js >> @@ -123,7 +123,7 @@ Ext.define('PVE.pool.AddStorage', { >> me.isAdd = true; >> me.url = "/pools/"; >> me.method = 'PUT'; >> - me.extraRequestParams.poolid = me.pool; >> + me.extraRequestParams = { 'poolid': me.pool }; > > note that you don't need to quote `poolid` here as it doesn't contain > hyphens as such. quickly grepping over our codebase it seems that not > quoting keys is preferred if it isn't needed You're right, thanks for spotting this (my Python upbringing got the better of me here). I'll send a v2 that fixes this, and will probably include a patch that rewrites the other occurrences of `extraRequestParams`.