[pve-devel] [PATCH proxmox_login_manager v2] refactor: replace deprecated functions and properties

[pve-devel] [PATCH proxmox_login_manager v2] refactor: replace deprecated functions and properties

[Shan Shaji]

As of flutter v3.22 the `background` property is deprecated. Also the
`withOpacity` function is also deprecated as of flutter v3.27.

This commit replaces the use of `background` property with
`surfaceContainer` to align with the changes made in the following
change [0] in `pve_flutter_frontend`. Additionaly the `withOpacity`
function is also replaced with `withValues` function.

- [0] https://lore.proxmox.com/all/20250505120355.31056-1-s.shaji@proxmox.com/

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
 
 changes since v1:
 * Removed all `dart fix` related changes

 lib/proxmox_login_form.dart     | 2 +-
 lib/proxmox_login_selector.dart | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart
index 5916563..94187f5 100644
--- a/lib/proxmox_login_form.dart
+++ b/lib/proxmox_login_form.dart
@@ -729,7 +729,7 @@ class ProxmoxProgressOverlay extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     return Container(
-      decoration: BoxDecoration(color: Colors.black.withOpacity(0.5)),
+      decoration: BoxDecoration(color: Colors.black.withValues(alpha: 0.5)),
       child: Center(
         child: Column(
           mainAxisAlignment: MainAxisAlignment.center,
diff --git a/lib/proxmox_login_selector.dart b/lib/proxmox_login_selector.dart
index fb1218b..ba84d7d 100644
--- a/lib/proxmox_login_selector.dart
+++ b/lib/proxmox_login_selector.dart
@@ -30,7 +30,7 @@ class _ProxmoxLoginSelectorState extends State<ProxmoxLoginSelector> {
   @override
   Widget build(BuildContext context) {
     return Scaffold(
-      backgroundColor: Theme.of(context).colorScheme.background,
+      backgroundColor: Theme.of(context).colorScheme.surfaceContainer,
       appBar: AppBar(
         centerTitle: false,
         title: const Column(
-- 
2.39.5 (Apple Git-154)



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH proxmox_login_manager v2] refactor: replace deprecated functions and properties

[Dominik Csapak]

On 5/22/25 10:34, Shan Shaji wrote:
> As of flutter v3.22 the `background` property is deprecated. Also the
> `withOpacity` function is also deprecated as of flutter v3.27.
> 
> This commit replaces the use of `background` property with
> `surfaceContainer` to align with the changes made in the following
> change [0] in `pve_flutter_frontend`. Additionaly the `withOpacity`
> function is also replaced with `withValues` function.
> 
> - [0] https://lore.proxmox.com/all/20250505120355.31056-1-s.shaji@proxmox.com/
> 
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>   
>   changes since v1:
>   * Removed all `dart fix` related changes
> 
>   lib/proxmox_login_form.dart     | 2 +-
>   lib/proxmox_login_selector.dart | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel