From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B6E7F1FF2CA for ; Tue, 23 Jul 2024 09:51:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 78E573D9B2; Tue, 23 Jul 2024 09:51:32 +0200 (CEST) Message-ID: <26ae8119-77e2-4e99-970f-31b0f7d31181@proxmox.com> Date: Tue, 23 Jul 2024 09:50:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Thomas Lamprecht , Proxmox VE development discussion References: <20240709114116.208276-1-a.lauterer@proxmox.com> <6fe6ba3b-fc25-4d5d-bb4f-6943a62a5947@proxmox.com> From: Aaron Lauterer In-Reply-To: <6fe6ba3b-fc25-4d5d-bb4f-6943a62a5947@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.039 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] applied: [PATCH manager] fix #5010: ceph: pool set only changed properties X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 2024-07-22 19:02, Thomas Lamprecht wrote: > > applied, thanks, one question still inline though. > > >> + if (defined($current_properties->{$setting}) && $value eq $current_properties->{$setting}) { > hmm, might this cause trouble (or at least noisy warnings) with properties > that are defined as integers in the schema (if we even convert those, not > sure from top of my head) or is this always in string form here? I might be missing some Perl intricacies here, but in all my tests it worked fine. The following test also works: perl -e 'use strict; use warnings; my $a = "1"; my $b = 1; if ($a eq $b) { print "YAY" };' Even if I set `$b = 1.0` _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel