From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A4ACFC010C for ; Wed, 10 Jan 2024 10:12:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7D7E330E7B for ; Wed, 10 Jan 2024 10:12:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 10 Jan 2024 10:12:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 807C84903F; Wed, 10 Jan 2024 10:12:10 +0100 (CET) Message-ID: <2668369e-0ace-4826-a443-6c6834adfa14@proxmox.com> Date: Wed, 10 Jan 2024 10:12:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner To: Proxmox VE development discussion , "DERUMIER, Alexandre" References: Content-Language: de-AT, en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.226 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, sourceware.org] Subject: Re: [pve-devel] qemu + tcmalloc for rbd X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2024 09:12:11 -0000 Am 09.01.24 um 18:02 schrieb DERUMIER, Alexandre: > Hi, > > I still have this last year patch pending > > https://lists.proxmox.com/pipermail/pve-devel/2023-May/056815.html > > to enabled conditionnaly tcmalloc in qemu > > It's still required for performance with librbd with last qemu /lirbd > I get a 30-40% performance boost in iops and latency for small > read/writes. > > > I would like to have a solution in proxmox repo, instead of maintain it > on my side. > > > Currently, In production, I compile qemu with tcmalloc at build. > > This patch serie, allow to do use LD_PRELOAD + disable malloc_trim() > call in qemu. > > I'm not expert in C (I re-used code from haproxy, which is doing > exactly the same thing with tcmalloc && trim). > So if somebody can review it, it could be great :) > Unfortunately, the QEMU patch seems rather hacky and I'd prefer to not include and maintain it. If tcmalloc would just provide malloc_trim() (e.g. as a no-op), there would be no need for the ugly at-runtime-detection at all. > > Another way (maybe safer), is to build 2 binary in same package > (/usr/bin/kvm-tcmalloc && /usr/bin/kvm), and give option to user to > choose it. > If we go for this route, I'd rather have two conflicting packages to avoid the redundant space usage for most people. Or if we really want to support being able to use both on a single system, an add-on kind of package with just the second binary. For reference, since it's been a while, previous discussion: https://lists.proxmox.com/pipermail/pve-devel/2023-March/056129.html Maybe you'd also like to ping the upstream enhancement request for glibc? https://sourceware.org/bugzilla/show_bug.cgi?id=28050