From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 09B0F91F66 for ; Mon, 20 Mar 2023 16:57:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D65177128 for ; Mon, 20 Mar 2023 16:57:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 20 Mar 2023 16:57:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9474B45A03 for ; Mon, 20 Mar 2023 16:57:07 +0100 (CET) Message-ID: <261604d1-6cc6-05af-6d3f-4c4a0bb75484@proxmox.com> Date: Mon, 20 Mar 2023 16:57:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB, de-AT To: Proxmox VE development discussion , Aaron Lauterer References: <20230209131843.2163978-1-a.lauterer@proxmox.com> From: Thomas Lamprecht Autocrypt: addr=t.lamprecht@proxmox.com; keydata= xsFNBFsLjcYBEACsaQP6uTtw/xHTUCKF4VD4/Wfg7gGn47+OfCKJQAD+Oyb3HSBkjclopC5J uXsB1vVOfqVYE6PO8FlD2L5nxgT3SWkc6Ka634G/yGDU3ZC3C/7NcDVKhSBI5E0ww4Qj8s9w OQRloemb5LOBkJNEUshkWRTHHOmk6QqFB/qBPW2COpAx6oyxVUvBCgm/1S0dAZ9gfkvpqFSD 90B5j3bL6i9FIv3YGUCgz6Ue3f7u+HsEAew6TMtlt90XV3vT4M2IOuECG/pXwTy7NtmHaBQ7 UJBcwSOpDEweNob50+9B4KbnVn1ydx+K6UnEcGDvUWBkREccvuExvupYYYQ5dIhRFf3fkS4+ wMlyAFh8PQUgauod+vqs45FJaSgTqIALSBsEHKEs6IoTXtnnpbhu3p6XBin4hunwoBFiyYt6 YHLAM1yLfCyX510DFzX/Ze2hLqatqzY5Wa7NIXqYYelz7tXiuCLHP84+sV6JtEkeSUCuOiUY virj6nT/nJK8m0BzdR6FgGtNxp7RVXFRz/+mwijJVLpFsyG1i0Hmv2zTn3h2nyGK/I6yhFNt dX69y5hbo6LAsRjLUvZeHXpTU4TrpN/WiCjJblbj5um5eEr4yhcwhVmG102puTtuCECsDucZ jpKpUqzXlpLbzG/dp9dXFH3MivvfuaHrg3MtjXY1i+/Oxyp5iwARAQABzTNUaG9tYXMgTGFt cHJlY2h0IChBdXRoLTQpIDx0LmxhbXByZWNodEBwcm94bW94LmNvbT7CwY4EEwEIADgWIQQO R4qbEl/pah9K6VrTZCM6gDZWBgUCWwuNxgIbAwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAK CRDTZCM6gDZWBm/jD/4+6JB2s67eaqoP6x9VGaXNGJPCscwzLuxDTCG90G9FYu29VcXtubH/ bPwsyBbNUQpqTm/s4XboU2qpS5ykCuTjqavrcP33tdkYfGcItj2xMipJ1i3TWvpikQVsX42R G64wovLs/dvpTYphRZkg5DwhgTmy3mRkmofFCTa+//MOcNOORltemp984tWjpR3bUJETNWpF sKGZHa3N4kCNxb7A+VMsJZ/1gN3jbQbQG7GkJtnHlWkw9rKCYqBtWrnrHa4UAvSa9M/XCIAB FThFGqZI1ojdVlv5gd6b/nWxfOPrLlSxbUo5FZ1i/ycj7/24nznW1V4ykG9iUld4uYUY86bB UGSjew1KYp9FmvKiwEoB+zxNnuEQfS7/Bj1X9nxizgweiHIyFsRqgogTvLh403QMSGNSoArk tqkorf1U+VhEncIn4H3KksJF0njZKfilrieOO7Vuot1xKr9QnYrZzJ7m7ZxJ/JfKGaRHXkE1 feMmrvZD1AtdUATZkoeQtTOpMu4r6IQRfSdwm/CkppZXfDe50DJxAMDWwfK2rr2bVkNg/yZI tKLBS0YgRTIynkvv0h8d9dIjiicw3RMeYXyqOnSWVva2r+tl+JBaenr8YTQw0zARrhC0mttu cIZGnVEvQuDwib57QLqMjQaC1gazKHvhA15H5MNxUhwm229UmdH3KM7BTQRbC43GARAAyTkR D6KRJ9Xa2fVMh+6f186q0M3ni+5tsaVhUiykxjsPgkuWXWW9MbLpYXkzX6h/RIEKlo2BGA95 QwG5+Ya2Bo3g7FGJHAkXY6loq7DgMp5/TVQ8phsSv3WxPTJLCBq6vNBamp5hda4cfXFUymsy HsJy4dtgkrPQ/bnsdFDCRUuhJHopnAzKHN8APXpKU6xV5e3GE4LwFsDhNHfH/m9+2yO/trcD txSFpyftbK2gaMERHgA8SKkzRhiwRTt9w5idOfpJVkYRsgvuSGZ0pcD4kLCOIFrer5xXudk6 NgJc36XkFRMnwqrL/bB4k6Pi2u5leyqcXSLyBgeHsZJxg6Lcr2LZ35+8RQGPOw9C0ItmRjtY ZpGKPlSxjxA1WHT2YlF9CEt3nx7c4C3thHHtqBra6BGPyW8rvtq4zRqZRLPmZ0kt/kiMPhTM 8wZAlObbATVrUMcZ/uNjRv2vU9O5aTAD9E5r1B0dlqKgxyoImUWB0JgpILADaT3VybDd3C8X s6Jt8MytUP+1cEWt9VKo4vY4Jh5vwrJUDLJvzpN+TsYCZPNVj18+jf9uGRaoK6W++DdMAr5l gQiwsNgf9372dbMI7pt2gnT5/YdG+ZHnIIlXC6OUonA1Ro/Itg90Q7iQySnKKkqqnWVc+qO9 GJbzcGykxD6EQtCSlurt3/5IXTA7t6sAEQEAAcLBdgQYAQgAIBYhBA5HipsSX+lqH0rpWtNk IzqANlYGBQJbC43GAhsMAAoJENNkIzqANlYGD1sP/ikKgHgcspEKqDED9gQrTBvipH85si0j /Jwu/tBtnYjLgKLh2cjv1JkgYYjb3DyZa1pLsIv6rGnPX9bH9IN03nqirC/Q1Y1lnbNTynPk IflgvsJjoTNZjgu1wUdQlBgL/JhUp1sIYID11jZphgzfDgp/E6ve/8xE2HMAnf4zAfJaKgD0 F+fL1DlcdYUditAiYEuN40Ns/abKs8I1MYx7Yglu3RzJfBzV4t86DAR+OvuF9v188WrFwXCS RSf4DmJ8tntyNej+DVGUnmKHupLQJO7uqCKB/1HLlMKc5G3GLoGqJliHjUHUAXNzinlpE2Vj C78pxpwxRNg2ilE3AhPoAXrY5qED5PLE9sLnmQ9AzRcMMJUXjTNEDxEYbF55SdGBHHOAcZtA kEQKub86e+GHA+Z8oXQSGeSGOkqHi7zfgW1UexddTvaRwE6AyZ6FxTApm8wq8NT2cryWPWTF BDSGB3ujWHMM8ERRYJPcBSjTvt0GcEqnd+OSGgxTkGOdufn51oz82zfpVo1t+J/FNz6MRMcg 8nEC+uKvgzH1nujxJ5pRCBOquFZaGn/p71Yr0oVitkttLKblFsqwa+10Lt6HBxm+2+VLp4Ja 0WZNncZciz3V3cuArpan/ZhhyiWYV5FD0pOXPCJIx7WS9PTtxiv0AOS4ScWEUmBxyhFeOpYa DrEx In-Reply-To: <20230209131843.2163978-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v3 storage] deprecate mkdir option for create-path and create-sub-dirs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Mar 2023 15:57:10 -0000 Am 09/02/2023 um 14:18 schrieb Aaron Lauterer: > The `mkdir` option has two meanings[0][1] which are split up in `create= -path` > and `create-sub-dirs`. >=20 > The `create-path` option decides if the path to the storage is > automatically created or not. > The `create-sub-dirs` options decides if the default directory > structure (dump, images, ...) at the storage location is created. >=20 > The `mkdir` option is still working but will trigger a warning in the > logs. >=20 > As a side effect, this also fixes #3214 because the `create-path` optio= n > is now run after the `is_mountpoint` check in the `activate_storage` > method in DirPlugin.pm. >=20 > [0] https://lists.proxmox.com/pipermail/pve-devel/2020-December/046575.= html > [1] https://lists.proxmox.com/pipermail/pve-devel/2020-December/046576.= html >=20 > Reviewed-by: Fabian Gr=C3=BCnbichler > Signed-off-by: Aaron Lauterer > --- > This is the continuation of quite the old patch series [2]. We never > applied it prior to the release of Proxmox VE 7. Hopefully we can get i= t > into v8 so that we can think about dropping the 'mkdir' parameter in v9= =2E >=20 > I added the T-b: Fabian Gr=C3=BCnbichler [3] but feel free to remove it= if > you think that it has been too long ago :) You added the R-b, not T-b, but that's actually the right one so OK. But = you added it first, but first should always be the authors S-o-b. I.e., trail= ers should only be appended, not prefixed or the like. But that's a nit and could be easily addressed on applying, and actually = I was close on doing so, but IMO it's a bit to late for this now, we should= rather add this early in the 8.x release cycle instead and then we could actually think of removing it in 9.x - as it would be rather a to short time span applying it now and dropping it for 9.0 already - especially as= dir based external plugins are affected by this too and dropping it might= even warrant an APIAGE reset. Plus, I'd do the following changes on top: diff --git a/PVE/Storage/DirPlugin.pm b/PVE/Storage/DirPlugin.pm index 6fc1f27..560bb62 100644 --- a/PVE/Storage/DirPlugin.pm +++ b/PVE/Storage/DirPlugin.pm @@ -35,14 +35,13 @@ sub properties { type =3D> 'string', format =3D> 'pve-storage-path', }, mkdir =3D> { - description =3D> - "Deprecated, use the 'create-path' and " . - "'create-sub-dirs' options instead.", + description =3D> "Create the directory if it doesn't exist an= d populate it with default sub-dirs." + ." NOTE: Deprecated, use the 'create-path' and 'create-su= b-dirs' options instead.", type =3D> 'boolean', default =3D> 'yes', }, - 'create-path' =3D> { - description =3D> "Create the directory if it doesn't exist.",= + 'create-base-path' =3D> { + description =3D> "Create the base directory, if it doesn't ex= ist.", type =3D> 'boolean', default =3D> 'yes', }, The s/create-path/create-base-path/ is obviously not finished, just to ge= t the idea over, and the should_create_path helper should be renamed too, as current= ly it's named to generic and one would even expect it to take a path argument, as other= wise one asks "create _what_ path?" should_create_base_path or directly doing a config_= aware_base_mkdir that also hosts the path creation directly (no hard feelings on that thou= gh) Plus some adapting to newer style guideline stuff, e.g.: diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index 634f289..1674e36 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/Storage/Plugin.pm @@ -1365,8 +1365,7 @@ sub activate_storage { warn "${storeid}: 'mkdir' option is deprecated. Use 'create-path' or= 'create-sub-dirs' instead.\n" if defined($scfg->{mkdir}); =20 - return if defined($scfg->{'create-sub-dirs'}) - && !$scfg->{'create-sub-dirs'}; + return if defined($scfg->{'create-sub-dirs'}) && !$scfg->{'create-su= b-dirs'}; =20 # FIXME The mkdir option is deprecated and create-sub-dirs should be= used return if defined($scfg->{mkdir}) && !$scfg->{mkdir};