From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 703F78497 for ; Mon, 25 Apr 2022 08:45:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 67DC943B8 for ; Mon, 25 Apr 2022 08:45:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id F40FA43AC for ; Mon, 25 Apr 2022 08:45:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C5813428D5 for ; Mon, 25 Apr 2022 08:45:10 +0200 (CEST) Message-ID: <25de5c30-e963-1cac-d61d-74852ac7aacb@proxmox.com> Date: Mon, 25 Apr 2022 08:45:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Thomas Lamprecht , Proxmox VE development discussion References: <20220421112659.74011-1-f.ebner@proxmox.com> <20220421112659.74011-6-f.ebner@proxmox.com> From: Fabian Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.857 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 qemu-server 3/7] restore deactivate volumes: never die X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2022 06:45:11 -0000 Am 23.04.22 um 11:18 schrieb Thomas Lamprecht: > On 21.04.22 13:26, Fabian Ebner wrote: >> Such an error shouldn't abort the whole operation. >> >> Signed-off-by: Fabian Ebner >> --- >> >> No changes from v1. >> >> PVE/QemuServer.pm | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm >> index be0694f9..9a16b617 100644 >> --- a/PVE/QemuServer.pm >> +++ b/PVE/QemuServer.pm >> @@ -6460,7 +6460,8 @@ my $restore_deactivate_volumes = sub { >> push @$vollist, $volid if $volid; >> } >> >> - PVE::Storage::deactivate_volumes($storecfg, $vollist); >> + eval { PVE::Storage::deactivate_volumes($storecfg, $vollist); }; >> + print STDERR $@ if $@; > > why not use warn "$@" which normally also gets printed on stderr? > I kept it in line with how restore_destroy_volumes does it, but I can change it in v3. >> }; >> >> my $restore_destroy_volumes = sub { >