From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D9E5277173 for ; Thu, 21 Oct 2021 12:39:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D5AFB1CEC0 for ; Thu, 21 Oct 2021 12:39:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3379F1CEB1 for ; Thu, 21 Oct 2021 12:39:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 05BFB45F10 for ; Thu, 21 Oct 2021 12:39:37 +0200 (CEST) Message-ID: <25da0489-dc1e-a5c3-fc6b-ea0f8e0c80c4@proxmox.com> Date: Thu, 21 Oct 2021 12:39:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20211011121024.921936-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211011121024.921936-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.186 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH qemu-server v2] use non SMM ovmf code file for i440fx machines X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2021 10:39:37 -0000 On 11.10.21 14:10, Dominik Csapak wrote: > ovmf with SMM enabled will not boot on i440fx (hangs on graphics > initialization), so load the non SMM variant. > > should be no issue regarding live-migration since it never worked with > this anyway. > > adapts the test and adds one with q35 > > Signed-off-by: Dominik Csapak > --- > changes from v1: > * encode 'no-smm' instead of machine type in the ovmf hash > * move the is_q35 checks out of the get_ovmf_files > > PVE/API2/Qemu.pm | 4 ++- > PVE/QemuServer.pm | 26 +++++++++++------ > test/cfg2cmd/efi-secboot-and-tpm-q35.conf | 6 ++++ > test/cfg2cmd/efi-secboot-and-tpm-q35.conf.cmd | 28 +++++++++++++++++++ > test/cfg2cmd/efi-secboot-and-tpm.conf | 2 +- > test/cfg2cmd/efi-secboot-and-tpm.conf.cmd | 2 +- > 6 files changed, 57 insertions(+), 11 deletions(-) > create mode 100644 test/cfg2cmd/efi-secboot-and-tpm-q35.conf > create mode 100644 test/cfg2cmd/efi-secboot-and-tpm-q35.conf.cmd > > With Stefan's T-b and R-b applied, thanks!