Re: [pve-devel] [RFC PATCH http-server 1/2] add error message into http body

[Dominik Csapak <d.csapak@proxmox.com>]

On 1/28/25 15:24, Thomas Lamprecht wrote:
> Am 27.01.25 um 13:44 schrieb Dominik Csapak:
>> any new input on this?
>>
>> I have thought about blindly adding 'plain/text' to it or do an 'encode_json("$msg")' and adding
>> 'application/json', but both options don't seem very sensible to me, as they're altering
>> the content type for all errors the api returns. This might trip up some clients.
>> (whereas before we did not set it so the client was free to guess or ignore the body content,
>> even if it was set)
> 
> Thanks for the clarification, leaving it as is can be fine then.
> But maybe add a short comment with rationale from your reply here.
> 

great, sent a v2:

https://lore.proxmox.com/pve-devel/20250128144125.3589111-1-d.csapak@proxmox.com/T/#t

(short question: is going from rfc -> v2 alright with you? or should i do
rfc -> v1 -> v2 in the future? looking at my past series i did both, but would
like to do that consistently. maybe it's even a thing to write in the dev docs?)


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel