From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3C5BD9BACC for ; Tue, 21 Nov 2023 12:46:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 818777A7F for ; Tue, 21 Nov 2023 12:45:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 21 Nov 2023 12:45:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 901F041009 for ; Tue, 21 Nov 2023 12:45:39 +0100 (CET) Date: Tue, 21 Nov 2023 12:45:38 +0100 (CET) From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= To: Proxmox VE development discussion , Stoiko Ivanov Message-ID: <245534943.479.1700567138619@webmail.proxmox.com> In-Reply-To: <20231121110959.550051-2-s.ivanov@proxmox.com> References: <20231121110959.550051-1-s.ivanov@proxmox.com> <20231121110959.550051-2-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev54 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH installer 1/2] zfs: set canmount=off on /var/lib X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2023 11:46:11 -0000 > Stoiko Ivanov hat am 21.11.2023 12:09 CET geschrieben: > > > as explained in zfsprops(4) setting canmount to off is similar to > setting mountpoint to none - except that you can still use the dataset > for storing properties to be inherited to children (and we want > /var/lib/vz to have a mountpoint set) > > Follows recommendations from upstreams ZFS on / guide: > https://openzfs.github.io/openzfs-docs/Getting%20Started/Debian/Debian%20Bookworm%20Root%20on%20ZFS.html > > Fixes: dd19d40ceac179ba18652f1d6c3e4c23f246af00 > Signed-off-by: Stoiko Ivanov > --- > Proxmox/Install.pm | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm > index 1a4ee93..fd9bf84 100644 > --- a/Proxmox/Install.pm > +++ b/Proxmox/Install.pm > @@ -189,6 +189,10 @@ sub zfs_create_rpool { > syscmd("zfs create $pool_name/data") == 0 || die "unable to create zfs $pool_name/data volume\n"; > syscmd("zfs create -p $pool_name/ROOT/$root_volume_name/var/lib/vz") == 0 || > die "unable to create zfs $pool_name/ROOT/$root_volume_name/var/lib/vz volume\n"; > + syscmd("zfs set canmount=off $pool_name/ROOT/$root_volume_name/var/lib") == 0 || > + die "unable to set canmount property on $pool_name/ROOT/$root_volume_name/var/lib\n"; > + syscmd("zfs set canmount=off $pool_name/ROOT/$root_volume_name/var") == 0 || > + die "unable to set canmount property on $pool_name/ROOT/$root_volume_name/var\n"; what's the advantage of this as opposed to zfs create -o mountpoint=/var/lib/vz $pool_name/var-lib-vz (or some other name for the dataset) > } > > # default to `relatime` on, fast enough for the installer and production > -- > 2.39.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel