From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B62781FF39E for ; Mon, 10 Jun 2024 16:12:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D706A18ED9; Mon, 10 Jun 2024 16:12:42 +0200 (CEST) Message-ID: <23ec758b-2f7a-429d-8ae7-916369656f44@proxmox.com> Date: Mon, 10 Jun 2024 16:12:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Jing Luo , pve-devel@lists.proxmox.com References: <94ed3b8c-20bf-4832-9ee8-f5b74e7b55f6@proxmox.com> <20240610122909.1216178-2-jing@jing.rocks> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20240610122909.1216178-2-jing@jing.rocks> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: [PATCH v2 pve-qemu-kvm] patches: pbs block driver: correct a data type X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 10.06.24 um 14:05 schrieb Jing Luo: > gcc warns (-Werror=type-limits) that it will always be false for the > if statement. This is because here s->aid is defined as char, while > proxmox_restore_open_image() returns an int. > > This is probably because chars are treated as unsigned on arm arch but > signed on x86 arch: > > https://developer.arm.com/documentation/den0013/d/Porting/Miscellaneous-C-porting-issues/unsigned-char-and-signed-char > > Signed-off-by: Jing Luo > -- applied, thanks! Here, a '-' was missing, so the below stuff would still be interpreted as part of the commit message. I fixed that when applying, improved the message slightly and made a follow-up to have a dedicated error message for when the returned value is too large. Best Regards, Fiona _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel