From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 15EEEA1699 for ; Thu, 15 Jun 2023 10:10:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E66CA23A41 for ; Thu, 15 Jun 2023 10:10:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 15 Jun 2023 10:10:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 43B904571B for ; Thu, 15 Jun 2023 10:10:04 +0200 (CEST) Message-ID: <23e96266-506a-2e2e-5892-d7a60fbb7b82@proxmox.com> Date: Thu, 15 Jun 2023 10:10:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Dominik Csapak To: pve-devel@lists.proxmox.com Reply-To: Proxmox VE development discussion References: <20230615080815.921858-1-d.csapak@proxmox.com> Content-Language: en-US In-Reply-To: <20230615080815.921858-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jun 2023 08:10:35 -0000 forgot to write: we should apply this for stable-7 as well On 6/15/23 10:08, Dominik Csapak wrote: > this field has a fixed height, which is too tall for the create wizard, > and one cannot see the last entry when scrolling all the way down. > > to fix this, make it 20px shorter > > Signed-off-by: Dominik Csapak > --- > alternatively we could also increase the height in the create wizard > > the optimal solution would be to improve the layouting in our > wizard/inputpanel altogether so that it automatically gets the right > height, but that is a non-trivial rework there. imho this should work > fine as a stopgap fix for now > > (feel free to put above comment into the commit message if it seems > appropriate) > > www/manager6/form/VMCPUFlagSelector.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js > index ace3c531..03a119ab 100644 > --- a/www/manager6/form/VMCPUFlagSelector.js > +++ b/www/manager6/form/VMCPUFlagSelector.js > @@ -12,7 +12,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', { > hideHeaders: true, > > scrollable: 'y', > - height: 200, > + height: 180, > > unkownFlags: [], >