From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7D0A91FF13F for ; Thu, 12 Mar 2026 14:55:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BFC6017F20; Thu, 12 Mar 2026 14:55:49 +0100 (CET) Message-ID: <23b2f4d7-01f5-4143-b0e4-569d8809888b@proxmox.com> Date: Thu, 12 Mar 2026 14:55:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-manager v2] fix #7300: acl path include pre-generated zones and fabrics To: pve-devel@lists.proxmox.com References: <20260311094220.36579-1-d.riley@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20260311094220.36579-1-d.riley@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.723 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: N6RWRGR3CGKC46YMJ3BV6WLH6ILWS2HB X-Message-ID-Hash: N6RWRGR3CGKC46YMJ3BV6WLH6ILWS2HB X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for looking into this! Tested this patch series on my machine and works as advertised - comments inline. On 3/11/26 10:42 AM, David Riley wrote: > Permission Path selection will show: > '/sdn/zones/' > '/sdn/fabrics/' > > The case 'network' is used because this will act as the top-level > resource for all networking entities (including SDN). > > see: https://git.proxmox.com/?p=pve-manager.git;a=commit;h=9ac04d9572a458aeb891feb9b695d793cf7b122d > Signed-off-by: David Riley > --- When sending a new version of a patch series it is good to include a changelog for the patch series. This makes life easier for people reviewing the patch series and allows for easily seeing what changed. Even if nothing really changed (afaict the Signed-off-by tag was missing and has been added) it makes it easy to tell that nothing significant changed from v1 ;) > www/manager6/data/PermPathStore.js | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/www/manager6/data/PermPathStore.js b/www/manager6/data/PermPathStore.js > index c7ec4231..bba7c7e7 100644 > --- a/www/manager6/data/PermPathStore.js > +++ b/www/manager6/data/PermPathStore.js > @@ -22,7 +22,7 @@ Ext.define('PVE.data.PermPathStore', { > ], > > constructor: function (config) { > - var me = this; > + let me = this; nit: this is not strictly related to the change and it might be better to send as an upfront / separate patch. > > config = config || {}; > > @@ -36,6 +36,9 @@ Ext.define('PVE.data.PermPathStore', { > case 'node': > path = '/nodes/' + record.get('text'); > break; > + case 'network': > + path = '/sdn/' + record.data['network-type'] + 's/' + record.data.network; nit: the surrounding code utilizes .get() - so it'd make sense to do the same here for the sake of consistency. Unless there is a specific reason for accessing record.data directly? > + break; > case 'qemu': > path = '/vms/' + record.get('vmid'); > break;