From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C01C11FF17C for ; Wed, 23 Jul 2025 17:52:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 661A917CE8; Wed, 23 Jul 2025 17:53:49 +0200 (CEST) Message-ID: <2388a286-8086-41f4-97fb-1b796714b9d0@proxmox.com> Date: Wed, 23 Jul 2025 17:53:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , pve-devel@lists.proxmox.com References: <20250723142106.235104-1-s.hanreich@proxmox.com> <175328294843.3720382.10504362558256531970.b4-ty@proxmox.com> <0ea3edeb-a110-455e-812e-7b9f019d6c77@proxmox.com> <8fc4304b-f718-4881-ad0a-3b9495badeb9@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <8fc4304b-f718-4881-ad0a-3b9495badeb9@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.703 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] applied: [PATCH pve-common 1/1] inotify/interfaces: use 'ip link' instead of /proc/net/dev X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 7/23/25 17:33, Thomas Lamprecht wrote: > Am 23.07.25 um 17:16 schrieb Stefan Hanreich: >> On 7/23/25 17:06, Thomas Lamprecht wrote: >> >> [snip] >> >>> I do not recall for sure anymore, but do differing bridge-ports work >>> transparently with the ifupdown2 changes from Christoph. With that it might be >>> nice to support it here too in the midterm, but that is certainly not a blocker >>> for now. >> >> I'm not sure if I understand 100% - do you mean if the name used in >> bridge-ports differs from the name of the referenced interface in >> /e/n/i? That doesn't work currently, since the validation breaks. > > Yeah no, I mean does it work for ifupdown2 now? As every situation > that works there but confuses our e/n/i parser is naturally not ideal > (for the long term). It does work there atm (just re-checked). >> I've discussed this initially with Dominik today, and we'd need to >> resolve altnames every time we look up names from bridge-ports, etc. > > That sounds like this is some expensive and high frequency operation, > but isn't it really only required when managing the node network or > wanting to do getting all available interfaces or doing some sanity > checks, i.e. things that invovle parsing the network config, where we > now have the altname map queried anyway? > > Or am I overlooking something? I meant in the context of reading/writing the interfaces file. I haven't 100% thought it through, and I might be missing something critical, but afaict it is as you said: We'd have to do it when reading / writing the network configuration from /e/n/i and in the pve-manager Network API when updating, since it does some additional checks (e.g. check_duplicate_ports) before writing via the function in INotify. >> If we want to support mixing names in the configuration, then we'd >> additionally have to construct a temporary, merged, configuration and >> validate against that. > > If ifupdown2 currently still doesn't supports that we're good in any > case, if it supports it would be nice to keep our stack consistent with > ifudpown2, but as hinted, not pressing now especially as our stack, as > you mentioned, never creates such a mixed config anyway. see above, fully supporting the current ifupdown2 capabilities will require untangling. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel