From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8AC101FF13B for ; Wed, 11 Mar 2026 16:58:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A007831DF6; Wed, 11 Mar 2026 16:58:14 +0100 (CET) Message-ID: <2351c696-e05c-4994-bdfc-0e98a9c7366b@proxmox.com> Date: Wed, 11 Mar 2026 16:58:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH manager 7/7] ui: qga: hide freeze-fs-on-backup check if undefined To: Maximiliano Sandoval , pve-devel@lists.proxmox.com References: <20260225154614.681858-1-m.sandoval@proxmox.com> <20260225154614.681858-8-m.sandoval@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260225154614.681858-8-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773244655637 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MX45F3Q72AXNEZ2B6YKK5XWJTJYIXTSB X-Message-ID-Hash: MX45F3Q72AXNEZ2B6YKK5XWJTJYIXTSB X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 25.02.26 um 4:46 PM schrieb Maximiliano Sandoval: > If the freeze-fs-on-backup key is not explicitly set on the config file > we hide the corresponding checkbox and hint. > > Note that when the checkbox is unchecked we delete the value from the > config resulting. > > Signed-off-by: Maximiliano Sandoval > --- > www/manager6/form/AgentFeatureSelector.js | 21 ++++++++++++++++++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js > index 1a87182d..deb774c1 100644 > --- a/www/manager6/form/AgentFeatureSelector.js > +++ b/www/manager6/form/AgentFeatureSelector.js > @@ -2,7 +2,18 @@ Ext.define('PVE.form.AgentFeatureSelector', { > extend: 'Proxmox.panel.InputPanel', > alias: ['widget.pveAgentFeatureSelector'], > > - viewModel: {}, > + viewModel: { > + data: { > + hideFreezeFsOnBackup: true, > + freezeFsOnBackupChecked: true, > + }, > + > + formulas: { > + hideFreezeFsOnBackupNotes: function (get) { > + return get('freezeFsOnBackupChecked') || get('hideFreezeFsOnBackup'); > + }, > + }, > + }, > > items: [ > { > @@ -71,9 +82,10 @@ Ext.define('PVE.form.AgentFeatureSelector', { > xtype: 'proxmoxcheckbox', > boxLabel: gettext('Deprecated. Freeze/thaw guest filesystems on backup for consistency'), > name: 'freeze-fs-on-backup', > - reference: 'freeze_fs_on_backup', > bind: { > disabled: '{!enabled.checked}', > + value: '{freezeFsOnBackupChecked}', > + hidden: '{hideFreezeFsOnBackup}', > }, > disabled: true, > uncheckedValue: '0', > @@ -86,7 +98,7 @@ Ext.define('PVE.form.AgentFeatureSelector', { > 'Freeze/thaw for guest filesystems disabled. This can lead to inconsistent disk backups.', > ), > bind: { > - hidden: '{freeze_fs_on_backup.checked}', > + hidden: '{hideFreezeFsOnBackupNotes}', > }, > }, > ], > @@ -105,10 +117,13 @@ Ext.define('PVE.form.AgentFeatureSelector', { > > setValues: function (values) { > let me = this; > + let vm = me.getViewModel(); > > let res = PVE.Parser.parsePropertyString(values.agent, 'enabled'); > if (!Ext.isDefined(res['freeze-fs-on-backup'])) { > res['freeze-fs-on-backup'] = 1; > + } else { > + vm.set('hideFreezeFsOnBackup', false); Checking for definedness is not enough: it should only be visible if explicitly set to false, but not if explicitly set to true. > } > if (!Ext.isDefined(res['guest-fsfreeze'])) { > res['guest-fsfreeze'] = 1;