From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 891FC1FF142
	for <inbox@lore.proxmox.com>; Tue, 21 Apr 2026 14:36:14 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 8BBFD225DE;
	Tue, 21 Apr 2026 14:36:12 +0200 (CEST)
Message-ID: <231a34ce-06cb-40b7-b0d8-6238e368e60c@proxmox.com>
Date: Tue, 21 Apr 2026 14:35:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH pve-storage 7/7] api: add
 /nodes/<node>/storage/<storage>/identity route
To: Lukas Wagner <l.wagner@proxmox.com>, Fiona Ebner <f.ebner@proxmox.com>,
 pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com
References: <20260415115817.348947-1-l.wagner@proxmox.com>
 <20260415115817.348947-8-l.wagner@proxmox.com>
 <262d3355-b8ec-470c-8fed-32a7b151fee4@proxmox.com>
 <DHVBALQJTVEW.3J1RKLBCCGHJO@proxmox.com>
Content-Language: en-US
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <DHVBALQJTVEW.3J1RKLBCCGHJO@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1776774850003
X-SPAM-LEVEL: Spam detection results:  0
	AWL                    -0.048 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	POISEN_SPAM_PILL_3        0.1 random spam to be learned in bayes
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: L25NFHZVT5GRPYFGJDRU5K3XMFVME2SQ
X-Message-ID-Hash: L25NFHZVT5GRPYFGJDRU5K3XMFVME2SQ
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 17.04.26 um 11:10 schrieb Lukas Wagner:
> On Fri Apr 17, 2026 at 10:54 AM CEST, Fiona Ebner wrote:
>> Am 15.04.26 um 1:57 PM schrieb Lukas Wagner:
>>> @@ -308,6 +308,7 @@ __PACKAGE__->register_method({
>>>              { subdir => 'download-url' },
>>>              { subdir => 'file-restore' },
>>>              { subdir => 'import-metadata' },
>>> +            { subdir => 'identity' },
>>
>> Just bike-shedding, but I'm wondering if 'identifier' would be slightly
>> more natural?
> 
> I can change it if you prefer, but I think I prefer 'identity', if I'm
> honest.
Why not "instance-id"? it's used widely in this series and is IMO quite
descriptive.