From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 671561FF176
for <inbox@lore.proxmox.com>; Fri, 24 Jan 2025 11:25:51 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id BEA371D0F4;
Fri, 24 Jan 2025 11:25:46 +0100 (CET)
Message-ID: <2319e84f-ace6-40ae-be8c-6dd4302d9023@proxmox.com>
Date: Fri, 24 Jan 2025 11:25:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20250124100811.32895-1-f.ebner@proxmox.com>
<20250124100811.32895-3-f.ebner@proxmox.com>
<7d2e0989-3d6e-40b5-b1b8-bd040d7c94a8@proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <7d2e0989-3d6e-40b5-b1b8-bd040d7c94a8@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.044 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pve-devel] [PATCH qemu-server 2/3] config: introduce a flag to
prevent writing the configuration
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Am 24.01.25 um 11:18 schrieb Thomas Lamprecht:
> Am 24.01.25 um 11:08 schrieb Fiona Ebner:
>> +sub write_config {
>> + my ($class, $vmid, $conf) = @_;
>> +
>> + if ($conf->{'no-write-config'}) {
>> + log_warn("refusing to write temporary configuration with 'no-write-config' flag");
>
> hmm, mixing config values and metadata for control flow/debugging is
> always getting hairy fast, making the config a blessed object with
> method for QEMU stuff and a clean separation of config data and such
> flags and other non-config data info might be a better alternative,
> but demanding that now would add a ton of scope and delay the fix
> significantly, so fine to go this way as stop gap.
>
> On a v2 or on applying adding a (one of) fixme/todo/hack comment to
> note that this is not ideal, to minimize the chance that doing this
> sort of thing spreads, could be good though.
>
Ack, will add such a FIXME comment.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel